Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace classnames with clsx #1409

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Replace classnames with clsx #1409

merged 1 commit into from
Jul 12, 2020

Conversation

@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.375% when pulling 45d933d on cahna:clsx into 1a45dc4 on gregnb:v3_2_0.

@cahna
Copy link
Author

cahna commented Jul 11, 2020

I may become a regular around here. After extensive research, this seems to be the best available table component for my needs. I would be happy to help-out on weekends with any small tasks/busywork you may want to delegate.
I can also help with an iterative migration to TypeScript and/or Jest+@testing-library/react if they are desired. Or if there is any desire to add cypress tests (ie: for DnD coverage), I can help there.

@patorjk
Copy link
Collaborator

patorjk commented Jul 11, 2020

I'm pretty open to ideas. I'm not really familiar enough with TypeScript to want to port over, though anything to make it more accessible to TypeScript users would be nice. Right now I believe most TypeScript users use the DefinitelyTyped project with this project. Not sure if there's a better way support could be offered.

Tests for DnD would be great! Don't feel obligated though. Anything you want to contribute would be appreciated.

@cahna
Copy link
Author

cahna commented Jul 12, 2020

A preview of DnD testing (cahna#1):
draggable-columns spec js

@patorjk patorjk merged commit eb36e3a into gregnb:v3_2_0 Jul 12, 2020
@patorjk patorjk mentioned this pull request Jul 12, 2020
@@ -97,7 +97,7 @@
"react-dom": "^16.8.0"
},
"dependencies": {
"classnames": "^2.2.6",
"clsx": "^1.1.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1415 Reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants