Skip to content

Commit

Permalink
Use checkstyle.
Browse files Browse the repository at this point in the history
  • Loading branch information
@gregorias
gregorias committed Sep 10, 2014
1 parent cc1fd1f commit c3a29a9
Show file tree
Hide file tree
Showing 56 changed files with 2,974 additions and 2,832 deletions.
1 change: 1 addition & 0 deletions build.gradle
View file
@@ -1,5 +1,6 @@
apply plugin: 'java'
apply plugin: 'eclipse'
apply plugin: 'checkstyle'
apply plugin: 'findbugs'
apply plugin: 'sonar-runner'

Expand Down
136 changes: 136 additions & 0 deletions config/checkstyle/checkstyle.xml
View file
@@ -0,0 +1,136 @@
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
"-//Puppy Crawl//DTD Check Configuration 1.3//EN"
"http://www.puppycrawl.com/dtds/configuration_1_3.dtd">

<!--
Checkstyle configurartion that checks the Google coding conventions from:
- Google Java Style
https://google-styleguide.googlecode.com/svn-history/r130/trunk/javaguide.html
Checkstyle is very configurable. Be sure to read the documentation at
http://checkstyle.sf.net (or in your downloaded distribution).
Most Checks are configurable, be sure to consult the documentation.
To completely disable a check, just comment it out or delete it from the file.
Authors: Max Vetrenko, Ruslan Diachenko, Roman Ivanov.
-->

<module name = "Checker">
<property name="charset" value="UTF-8"/>

<property name="severity" value="warning"/>

<!-- Checks for whitespace -->
<!-- See http://checkstyle.sf.net/config_whitespace.html -->
<module name="FileTabCharacter">
<property name="eachLine" value="true"/>
</module>

<module name="TreeWalker">
<module name="OuterTypeFilename"/>
<module name="IllegalTokenText">
<property name="tokens" value="STRING_LITERAL, CHAR_LITERAL"/>
<property name="format" value="\\u00(08|09|0(a|A)|0(c|C)|0(d|D)|22|27|5(C|c))|\\(0(10|11|12|14|15|42|47)|134)"/>
<property name="message" value="Avoid using corresponding octal or Unicode escape."/>
</module>
<module name="LineLength">
<property name="max" value="100"/>
<property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
</module>
<module name="AvoidStarImport"/>
<module name="EmptyBlock">
<property name="option" value="TEXT"/>
<property name="tokens" value="LITERAL_TRY, LITERAL_CATCH, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"/>
</module>
<module name="NeedBraces"/>
<module name="LeftCurly">
<property name="maxLineLength" value="100"/>
</module>
<module name="RightCurly">
<property name="option" value="alone"/>
<property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"/>
</module>
<module name="WhitespaceAround">
<property name="allowEmptyConstructors" value="true"/>
<property name="allowEmptyMethods" value="true"/>
<message key="ws.notFollowed"
value="WhitespaceAround: ''{0}'' is not followed by whitespace."/>
<message key="ws.notPreceded"
value="WhitespaceAround: ''{0}'' is not preceded with whitespace."/>
</module>
<module name="OneStatementPerLine"/>
<module name="MultipleVariableDeclarations"/>
<module name="ArrayTypeStyle"/>
<module name="MissingSwitchDefault"/>
<module name="FallThrough"/>
<module name="UpperEll"/>
<module name="ModifierOrder"/>
<module name="PackageName">
<property name="format" value="^[a-z]+(\.[a-z][a-z0-9]*)*$"/>
<message key="name.invalidPattern"
value="Package name ''{0}'' must match pattern ''{1}''."/>
</module>
<module name="TypeName">
<message key="name.invalidPattern"
value="Type name ''{0}'' must match pattern ''{1}''."/>
</module>
<module name="MemberName">
<property name="format" value="^m[a-zA-Z][a-zA-Z0-9]*$"/>
<message key="name.invalidPattern"
value="Member name ''{0}'' must match pattern ''{1}''."/>
</module>
<module name="ParameterName">
<property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>
<message key="name.invalidPattern"
value="Parameter name ''{0}'' must match pattern ''{1}''."/>
</module>
<module name="LocalVariableName">
<property name="tokens" value="VARIABLE_DEF"/>
<property name="format" value="^[a-z][a-z0-9][a-zA-Z0-9]*$"/>
<message key="name.invalidPattern"
value="Local variable name ''{0}'' must match pattern ''{1}''."/>
</module>
<module name="ClassTypeParameterName">
<property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
<message key="name.invalidPattern"
value="Class type name ''{0}'' must match pattern ''{1}''."/>
</module>
<module name="MethodTypeParameterName">
<property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
<message key="name.invalidPattern"
value="Method type name ''{0}'' must match pattern ''{1}''."/>
</module>
<module name="NoFinalizer"/>
<module name="GenericWhitespace">
<message key="ws.followed"
value="GenericWhitespace ''{0}'' is followed by whitespace."/>
<message key="ws.preceded"
value="GenericWhitespace ''{0}'' is preceded with whitespace."/>
<message key="ws.illegalFollow"
value="GenericWhitespace ''{0}'' should followed by whitespace."/>
<message key="ws.notPreceded"
value="GenericWhitespace ''{0}'' is not preceded with whitespace."/>
</module>
<module name="Indentation">
<property name="basicOffset" value="2"/>
<property name="braceAdjustment" value="0"/>
<property name="caseIndent" value="2"/>
<property name="throwsIndent" value="2"/>
</module>
<module name="MethodParamPad"/>
<module name="OperatorWrap">
<property name="option" value="NL"/>
<property name="tokens" value="BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "/>
</module>
</module>
<module name="RegexpSingleline">
<property name="format" value="\s+$"/>
<property name="message" value="Trailing whitespace is not allowed."/>
</module>
</module>
20 changes: 10 additions & 10 deletions src/main/java/org/nebulostore/kademlia/core/FindNodeMessage.java
View file
@@ -1,16 +1,16 @@
package org.nebulostore.kademlia.core;

class FindNodeMessage extends MessageWithKnownRecipient {
private static final long serialVersionUID = 1L;
private static final long serialVersionUID = 1L;

private final Key key_;
private final Key mKey;

public FindNodeMessage(NodeInfo srcNodeInfo, NodeInfo destNodeInfo, Key searchedKey) {
super(srcNodeInfo, destNodeInfo);
key_ = searchedKey;
}
public Key getSearchedKey() {
return key_;
}
public FindNodeMessage(NodeInfo srcNodeInfo, NodeInfo destNodeInfo, Key searchedKey) {
super(srcNodeInfo, destNodeInfo);
mKey = searchedKey;
}

public Key getSearchedKey() {
return mKey;
}
}
22 changes: 11 additions & 11 deletions src/main/java/org/nebulostore/kademlia/core/FindNodeReplyMessage.java
View file
Expand Up @@ -5,17 +5,17 @@
import java.util.LinkedList;

class FindNodeReplyMessage extends MessageWithKnownRecipient {
private static final long serialVersionUID = 1L;
private static final long serialVersionUID = 1L;

private final LinkedList<NodeInfo> foundNodes_;
private final LinkedList<NodeInfo> mFoundNodes;

public FindNodeReplyMessage(NodeInfo srcNodeInfo, NodeInfo destNodeInfo,
Collection<NodeInfo> foundNodes) {
super(srcNodeInfo, destNodeInfo);
foundNodes_ = new LinkedList<NodeInfo>(foundNodes);
}
public Collection<NodeInfo> getFoundNodes() {
return new ArrayList<>(foundNodes_);
}
public FindNodeReplyMessage(NodeInfo srcNodeInfo, NodeInfo destNodeInfo,
Collection<NodeInfo> foundNodes) {
super(srcNodeInfo, destNodeInfo);
mFoundNodes = new LinkedList<NodeInfo>(foundNodes);
}

public Collection<NodeInfo> getFoundNodes() {
return new ArrayList<>(mFoundNodes);
}
}
8 changes: 4 additions & 4 deletions src/main/java/org/nebulostore/kademlia/core/GetKeyMessage.java
View file
@@ -1,9 +1,9 @@
package org.nebulostore.kademlia.core;

class GetKeyMessage extends Message {
private static final long serialVersionUID = 1L;
private static final long serialVersionUID = 1L;

public GetKeyMessage(NodeInfo localNodeInfo) {
super(localNodeInfo);
}
public GetKeyMessage(NodeInfo localNodeInfo) {
super(localNodeInfo);
}
}
26 changes: 13 additions & 13 deletions src/main/java/org/nebulostore/kademlia/core/IdleMessageListener.java
View file
Expand Up @@ -2,22 +2,22 @@

/**
* {@link MessageListener} which does nothing and does not respond.
*
*
* @author Grzegorz Milka
*/
public class IdleMessageListener implements MessageListener {
@Override
public FindNodeReplyMessage receiveFindNodeMessage(FindNodeMessage msg) {
return null;
}
@Override
public FindNodeReplyMessage receiveFindNodeMessage(FindNodeMessage msg) {
return null;
}

@Override
public PongMessage receivePingMessage(PingMessage msg) {
return null;
}
@Override
public PongMessage receivePingMessage(PingMessage msg) {
return null;
}

@Override
public PongMessage receiveGetKeyMessage(GetKeyMessage msg) {
return null;
}
@Override
public PongMessage receiveGetKeyMessage(GetKeyMessage msg) {
return null;
}
}
26 changes: 13 additions & 13 deletions src/main/java/org/nebulostore/kademlia/core/IdleMessageResponseHandler.java
View file
Expand Up @@ -4,24 +4,24 @@

/**
* {@link MessageResponseHandler} which does nothing.
*
*
* @author Grzegorz Milka
*/
class IdleMessageResponseHandler implements MessageResponseHandler {

@Override
public void onResponse(Message response) {
}
@Override
public void onResponse(Message response) {
}

@Override
public void onResponseError(IOException e) {
}
@Override
public void onResponseError(IOException exception) {
}

@Override
public void onSendSuccessful() {
}
@Override
public void onSendSuccessful() {
}

@Override
public void onSendError(IOException e) {
}
@Override
public void onSendError(IOException exception) {
}
}
32 changes: 16 additions & 16 deletions src/main/java/org/nebulostore/kademlia/core/KademliaException.java
View file
@@ -1,26 +1,26 @@
package org.nebulostore.kademlia.core;

public class KademliaException extends Exception {
private static final long serialVersionUID = 1L;
private static final long serialVersionUID = 1L;

public KademliaException() {
}
public KademliaException() {
}

public KademliaException(String message) {
super(message);
}
public KademliaException(String message) {
super(message);
}

public KademliaException(Throwable cause) {
super(cause);
}
public KademliaException(Throwable cause) {
super(cause);
}

public KademliaException(String message, Throwable cause) {
super(message, cause);
}
public KademliaException(String message, Throwable cause) {
super(message, cause);
}

public KademliaException(String message, Throwable cause,
boolean enableSuppression, boolean writableStackTrace) {
super(message, cause, enableSuppression, writableStackTrace);
}
public KademliaException(String message, Throwable cause, boolean enableSuppression,
boolean writableStackTrace) {
super(message, cause, enableSuppression, writableStackTrace);
}

}

0 comments on commit c3a29a9

Please sign in to comment.