Merge pull request #400 from gregsdennis/patch/replace-missing-item

replicate issue

JsonPatch.Tests/GithubTests.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Text;
+using System.Text.Encodings.Web;
 using System.Text.Json;
 using System.Text.Json.Nodes;
 using Json.More;
@@ -53,10 +54,11 @@ public void Issue393_PatchDoesNothing()
 		var arrayObject = JsonDocument.Parse(arrayObjectJson).RootElement;
 
 		// Way 1: patch whole array
-		var patchedArray = patchConfig.Apply(arrayObject.AsNode()).Result;  // <- does nothing
+		var patchedArray = patchConfig.Apply(arrayObject.AsNode()).Result; // <- does nothing
 
 		Console.WriteLine(JsonSerializer.Serialize(patchedArray));
 	}
+
 	[Test]
 	public void Issue393_NodeAlreadyHasParent_2()
 	{
@@ -100,10 +102,11 @@ public void Issue393_NodeAlreadyHasParent_2()
 		// Way 2: just patch every element
 		foreach (var element in jsonArray)
 		{
-			var patchedNode = patchConfig.Apply(element).Result;            // <-  throws an error
+			var patchedNode = patchConfig.Apply(element).Result; // <-  throws an error
 			Console.WriteLine(JsonSerializer.Serialize(patchedNode));
 		}
 	}
+
 	[Test]
 	public void Issue393_NodeAlreadyHasParent_3()
 	{
@@ -150,8 +153,31 @@ public void Issue393_NodeAlreadyHasParent_3()
 			var nodeToPatch = jsonArray[currentIndex];
 			jsonArray.RemoveAt(currentIndex);
 
-			var patchedNode = patchConfig.Apply(nodeToPatch).Result;        // <-  throws an error
+			var patchedNode = patchConfig.Apply(nodeToPatch).Result; // <-  throws an error
 			Console.WriteLine(JsonSerializer.Serialize(patchedNode));
 		}
 	}
+
+	[Test]
+	public void Issue397_ReplaceShouldThrowForMissingValue()
+	{
+		const string mask = "*****";
+		var maskJson = JsonValue.Create(mask);
+
+		var pathsToPatch = new[] { "/first_name", "/last_name" };
+
+		var patchOperations = pathsToPatch.Select(path => PatchOperation.Replace(JsonPointer.Parse(path), maskJson));
+		var patchConfig = new JsonPatch(patchOperations);
+
+		const string singleObjectJson = @"{
+	""id"":""640729d45434f90313d25c78"",
+    ""guid"":""f2e2767c-03e0-4862-addc-7d46c55efb33"",
+	""city"":""Boston""
+}";
+
+		var singleObject = JsonNode.Parse(singleObjectJson);
+		var result = patchConfig.Apply(singleObject);
+		Console.WriteLine(JsonSerializer.Serialize(result, new JsonSerializerOptions { WriteIndented = true, Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping }));
+		Assert.IsNotNull(patchConfig.Apply(singleObject).Error);
+	}
 }

JsonPatch/JsonPatch.csproj

@@ -4,9 +4,9 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <LangVersion>latest</LangVersion>
     <RootNamespace>Json.Patch</RootNamespace>
-    <Version>2.0.5</Version>
+    <Version>2.0.6</Version>
     <AssemblyVersion>2.0.0.0</AssemblyVersion>
-    <FileVersion>2.0.5.0</FileVersion>
+    <FileVersion>2.0.6.0</FileVersion>
     <PackageId>JsonPatch.Net</PackageId>
     <Authors>Greg Dennis</Authors>
     <Company>Greg Dennis</Company>

JsonPatch/ReplaceOperationHandler.cs

@@ -18,9 +18,10 @@ public void Process(PatchContext context, PatchOperation operation)
 			return;
 		}
 
-		if (!operation.Path.EvaluateAndGetParent(context.Source, out var target))
+		if (!operation.Path.EvaluateAndGetParent(context.Source, out var target) ||
+			!operation.Path.TryEvaluate(context.Source, out _))
 		{
-			context.Message = $"Target path `{operation.From}` could not be reached.";
+			context.Message = $"Target path `{operation.Path}` could not be reached.";
 			return;
 		}
 

json-everything.net/wwwroot/md/release-notes/json-patch.md

@@ -1,6 +1,10 @@
+# [2.0.6](https://github.com/gregsdennis/json-everything/pull/400) {#release-patch-2.0.6}
+
+[#397](https://github.com/gregsdennis/json-everything/issues/397) - Fixed an issue where `replace` needs to check that the target location exists before proceeding with the `add` portion of its operation.
+
 # [2.0.5](https://github.com/gregsdennis/json-everything/pull/394) {#release-patch-2.0.5}
 
-[#393](https://github.com/gregsdennis/json-everything/pull/393) - Fixed an `InvalidOperationException` from some of the operations.
+[#393](https://github.com/gregsdennis/json-everything/issues/393) - Fixed an `InvalidOperationException` from some of the operations.
 
 # [2.0.4](https://github.com/gregsdennis/json-everything/pull/323) {#release-patch-2.0.4}