Merge pull request #425 from gregsdennis/pointer/indexoutofrange-for-…

…array jsonpointer - index out of range for array
gregsdennis · Mar 30, 2023 · 59f2ff5 · 59f2ff5
2 parents ea67872 + cff52fd
commit 59f2ff5
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 2 deletions.
diff --git a/JsonPointer.Tests/GithubTests.cs b/JsonPointer.Tests/GithubTests.cs
@@ -0,0 +1,19 @@
+using System.Text.Json.Nodes;
+using NUnit.Framework;
+
+namespace Json.Pointer.Tests;
+
+public class GithubTests
+{
+	[Test]
+	public void Issue408_ArrayDerefThrowsIndexOutOfRange()
+	{
+		var pointer = JsonPointer.Parse("/");
+		var data = JsonNode.Parse("[]");
+
+		var success = pointer.TryEvaluate(data, out var array);
+
+		Assert.IsFalse(success);
+		Assert.IsNull(array);
+	}
+}
diff --git a/JsonPointer/JsonPointer.cs b/JsonPointer/JsonPointer.cs
@@ -297,6 +297,7 @@ public bool TryEvaluate(JsonNode? root, out JsonNode? result)
 			{
 				case JsonArray array:
 					segmentValue = segment.Value;
+					if (segmentValue == string.Empty) return false;
 					if (segmentValue == "0")
 					{
 						if (array.Count == 0) return false;

diff --git a/JsonPointer/JsonPointer.csproj b/JsonPointer/JsonPointer.csproj
@@ -4,9 +4,9 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <LangVersion>latest</LangVersion>
     <RootNamespace>Json.Pointer</RootNamespace>
-    <Version>3.0.0</Version>
+    <Version>3.0.1</Version>
     <AssemblyVersion>3.0.0.0</AssemblyVersion>
-    <FileVersion>3.0.0</FileVersion>
+    <FileVersion>3.0.1.0</FileVersion>
     <PackageId>JsonPointer.Net</PackageId>
     <Authors>Greg Dennis</Authors>
     <Product>JsonPointer.Net</Product>

diff --git a/json-everything.net/wwwroot/md/release-notes/json-pointer.md b/json-everything.net/wwwroot/md/release-notes/json-pointer.md
@@ -1,3 +1,7 @@
+# [3.0.1](https://github.com/gregsdennis/json-everything/pull/425) {#release-pointer-3.0.1}
+
+[#408](https://github.com/gregsdennis/json-everything/issues/408) - Fixed an issue where an empty string segment fails for array values.  Thanks to [@mbj2011](https://github.com/mbj2011) for finding and reporting this.
+
 # [3.0.0](https://github.com/gregsdennis/json-everything/pull/326) {#release-pointer-3.0.0}
 
 Updated model to more correctly represent a basic JSON Pointer.