Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a keyword impl for unrecognized keywords instead of otherdata #270

Merged
merged 6 commits into from May 26, 2022

Conversation

gregsdennis
Copy link
Owner

Special request from @Relequestual. This has also be rolling around in my head for a few weeks anyway.

@github-actions
Copy link

Expand to see formatting issues
[
  {
    "DocumentId": {
      "ProjectId": {
        "Id": "6f73f141-f542-4fed-a100-2fb7c5a93aef"
      },
      "Id": "539b16e7-06a4-4058-8889-ca2f0370292a"
    },
    "FileName": "UnrecognizedKeyword.cs",
    "FilePath": "/home/runner/work/json-everything/json-everything/JsonSchema/UnrecognizedKeyword.cs",
    "FileChanges": [
      {
        "LineNumber": 6,
        "CharNumber": 23,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 2 characters with \u0027\\n\\n\u0027."
      },
      {
        "LineNumber": 17,
        "CharNumber": 2,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 2 characters with \u0027\\n\\t\u0027."
      },
      {
        "LineNumber": 21,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 1 characters with \u0027\\t\u0027."
      },
      {
        "LineNumber": 22,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 3 characters with \u0027\\n\\t\u0027."
      },
      {
        "LineNumber": 26,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 1 characters with \u0027\\t\u0027."
      },
      {
        "LineNumber": 26,
        "CharNumber": 35,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 3 characters with \u0027\\n\\n\\t\u0027."
      },
      {
        "LineNumber": 33,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 1 characters with \u0027\\t\u0027."
      },
      {
        "LineNumber": 37,
        "CharNumber": 3,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 3 characters with \u0027\\n\\n\\t\u0027."
      },
      {
        "LineNumber": 43,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 1 characters with \u0027\\t\u0027."
      },
      {
        "LineNumber": 49,
        "CharNumber": 3,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 3 characters with \u0027\\n\\n\\t\u0027."
      },
      {
        "LineNumber": 54,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 1 characters with \u0027\\t\u0027."
      },
      {
        "LineNumber": 59,
        "CharNumber": 3,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 3 characters with \u0027\\n\\n\\t\u0027."
      },
      {
        "LineNumber": 64,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 1 characters with \u0027\\t\u0027."
      },
      {
        "LineNumber": 67,
        "CharNumber": 3,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 3 characters with \u0027\\n\\n\\t\u0027."
      },
      {
        "LineNumber": 71,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 1 characters with \u0027\\t\u0027."
      }
    ]
  },
  {
    "DocumentId": {
      "ProjectId": {
        "Id": "e7f6654b-9bfa-4dbe-b02c-07ee1e1c07db"
      },
      "Id": "d0aeceba-b80f-4046-ad92-41e4e2e48d83"
    },
    "FileName": "AdditionalItemsAttribute.cs",
    "FilePath": "/home/runner/work/json-everything/json-everything/JsonSchema.Generation/AdditionalItemsAttribute.cs",
    "FileChanges": [
      {
        "LineNumber": 4,
        "CharNumber": 34,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 2 characters with \u0027\\n\\n\u0027."
      },
      {
        "LineNumber": 10,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 16 characters with \u0027\\t\\t\\t\\t\u0027."
      },
      {
        "LineNumber": 12,
        "CharNumber": 2,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 2 characters with \u0027\\n\\t\u0027."
      },
      {
        "LineNumber": 16,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 1 characters with \u0027\\t\u0027."
      },
      {
        "LineNumber": 16,
        "CharNumber": 33,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 2 characters with \u0027\\n\\t\u0027."
      },
      {
        "LineNumber": 20,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 1 characters with \u0027\\t\u0027."
      },
      {
        "LineNumber": 20,
        "CharNumber": 33,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 3 characters with \u0027\\n\\n\\t\u0027."
      },
      {
        "LineNumber": 26,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 1 characters with \u0027\\t\u0027."
      },
      {
        "LineNumber": 29,
        "CharNumber": 3,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 3 characters with \u0027\\n\\n\\t\u0027."
      },
      {
        "LineNumber": 35,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 1 characters with \u0027\\t\u0027."
      }
    ]
  },
  {
    "DocumentId": {
      "ProjectId": {
        "Id": "e7f6654b-9bfa-4dbe-b02c-07ee1e1c07db"
      },
      "Id": "8a6870c6-ef73-4b54-b426-75bdb29f8d1c"
    },
    "FileName": "AdditionalPropertiesAttribute.cs",
    "FilePath": "/home/runner/work/json-everything/json-everything/JsonSchema.Generation/AdditionalPropertiesAttribute.cs",
    "FileChanges": [
      {
        "LineNumber": 4,
        "CharNumber": 34,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 2 characters with \u0027\\n\\n\u0027."
      },
      {
        "LineNumber": 10,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 16 characters with \u0027\\t\\t\\t\\t\u0027."
      },
      {
        "LineNumber": 12,
        "CharNumber": 2,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 2 characters with \u0027\\n\\t\u0027."
      },
      {
        "LineNumber": 16,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 1 characters with \u0027\\t\u0027."
      },
      {
        "LineNumber": 16,
        "CharNumber": 33,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 2 characters with \u0027\\n\\t\u0027."
      },
      {
        "LineNumber": 20,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 1 characters with \u0027\\t\u0027."
      },
      {
        "LineNumber": 20,
        "CharNumber": 33,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 3 characters with \u0027\\n\\n\\t\u0027."
      },
      {
        "LineNumber": 26,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 1 characters with \u0027\\t\u0027."
      },
      {
        "LineNumber": 29,
        "CharNumber": 3,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 3 characters with \u0027\\n\\n\\t\u0027."
      },
      {
        "LineNumber": 35,
        "CharNumber": 1,
        "DiagnosticId": "WHITESPACE",
        "FormatDescription": "Fix whitespace formatting. Replace 1 characters with \u0027\\t\u0027."
      }
    ]
  },
  {
    "DocumentId": {
      "ProjectId": {
        "Id": "6f73f141-f542-4fed-a100-2fb7c5a93aef"
      },
      "Id": "9eb6c1e4-e417-4b8a-8625-eca14de874fa"
    },
    "FileName": "JsonSchema.cs",
    "FilePath": "/home/runner/work/json-everything/json-everything/JsonSchema/JsonSchema.cs",
    "FileChanges": [
      {
        "LineNumber": 62,
        "CharNumber": 3,
        "DiagnosticId": "CS0618",
        "FormatDescription": "warning CS0618: \u0027JsonSchema.OtherData\u0027 is obsolete: \u0027Unrecognized keyword data now appears as UnrecognizedKeyword instances in the Keywords collection.\u0027"
      }
    ]
  },
  {
    "DocumentId": {
      "ProjectId": {
        "Id": "6f73f141-f542-4fed-a100-2fb7c5a93aef"
      },
      "Id": "9eb6c1e4-e417-4b8a-8625-eca14de874fa"
    },
    "FileName": "JsonSchema.cs",
    "FilePath": "/home/runner/work/json-everything/json-everything/JsonSchema/JsonSchema.cs",
    "FileChanges": [
      {
        "LineNumber": 304,
        "CharNumber": 36,
        "DiagnosticId": "CS0618",
        "FormatDescription": "warning CS0618: \u0027JsonSchema.OtherData\u0027 is obsolete: \u0027Unrecognized keyword data now appears as UnrecognizedKeyword instances in the Keywords collection.\u0027"
      }
    ]
  },
  {
    "DocumentId": {
      "ProjectId": {
        "Id": "6f73f141-f542-4fed-a100-2fb7c5a93aef"
      },
      "Id": "9eb6c1e4-e417-4b8a-8625-eca14de874fa"
    },
    "FileName": "JsonSchema.cs",
    "FilePath": "/home/runner/work/json-everything/json-everything/JsonSchema/JsonSchema.cs",
    "FileChanges": [
      {
        "LineNumber": 305,
        "CharNumber": 6,
        "DiagnosticId": "CS0618",
        "FormatDescription": "warning CS0618: \u0027JsonSchema.OtherData\u0027 is obsolete: \u0027Unrecognized keyword data now appears as UnrecognizedKeyword instances in the Keywords collection.\u0027"
      }
    ]
  },
  {
    "DocumentId": {
      "ProjectId": {
        "Id": "6f73f141-f542-4fed-a100-2fb7c5a93aef"
      },
      "Id": "9eb6c1e4-e417-4b8a-8625-eca14de874fa"
    },
    "FileName": "JsonSchema.cs",
    "FilePath": "/home/runner/work/json-everything/json-everything/JsonSchema/JsonSchema.cs",
    "FileChanges": [
      {
        "LineNumber": 359,
        "CharNumber": 7,
        "DiagnosticId": "CS0618",
        "FormatDescription": "warning CS0618: \u0027JsonSchema.OtherData\u0027 is obsolete: \u0027Unrecognized keyword data now appears as UnrecognizedKeyword instances in the Keywords collection.\u0027"
      }
    ]
  },
  {
    "DocumentId": {
      "ProjectId": {
        "Id": "6f73f141-f542-4fed-a100-2fb7c5a93aef"
      },
      "Id": "9eb6c1e4-e417-4b8a-8625-eca14de874fa"
    },
    "FileName": "JsonSchema.cs",
    "FilePath": "/home/runner/work/json-everything/json-everything/JsonSchema/JsonSchema.cs",
    "FileChanges": [
      {
        "LineNumber": 359,
        "CharNumber": 27,
        "DiagnosticId": "CS0618",
        "FormatDescription": "warning CS0618: \u0027JsonSchema.OtherData\u0027 is obsolete: \u0027Unrecognized keyword data now appears as UnrecognizedKeyword instances in the Keywords collection.\u0027"
      }
    ]
  },
  {
    "DocumentId": {
      "ProjectId": {
        "Id": "6f73f141-f542-4fed-a100-2fb7c5a93aef"
      },
      "Id": "9eb6c1e4-e417-4b8a-8625-eca14de874fa"
    },
    "FileName": "JsonSchema.cs",
    "FilePath": "/home/runner/work/json-everything/json-everything/JsonSchema/JsonSchema.cs",
    "FileChanges": [
      {
        "LineNumber": 372,
        "CharNumber": 7,
        "DiagnosticId": "CS0618",
        "FormatDescription": "warning CS0618: \u0027JsonSchema.OtherData\u0027 is obsolete: \u0027Unrecognized keyword data now appears as UnrecognizedKeyword instances in the Keywords collection.\u0027"
      }
    ]
  },
  {
    "DocumentId": {
      "ProjectId": {
        "Id": "6f73f141-f542-4fed-a100-2fb7c5a93aef"
      },
      "Id": "9eb6c1e4-e417-4b8a-8625-eca14de874fa"
    },
    "FileName": "JsonSchema.cs",
    "FilePath": "/home/runner/work/json-everything/json-everything/JsonSchema/JsonSchema.cs",
    "FileChanges": [
      {
        "LineNumber": 374,
        "CharNumber": 16,
        "DiagnosticId": "CS0618",
        "FormatDescription": "warning CS0618: \u0027JsonSchema.OtherData\u0027 is obsolete: \u0027Unrecognized keyword data now appears as UnrecognizedKeyword instances in the Keywords collection.\u0027"
      }
    ]
  },
  {
    "DocumentId": {
      "ProjectId": {
        "Id": "6f73f141-f542-4fed-a100-2fb7c5a93aef"
      },
      "Id": "9eb6c1e4-e417-4b8a-8625-eca14de874fa"
    },
    "FileName": "JsonSchema.cs",
    "FilePath": "/home/runner/work/json-everything/json-everything/JsonSchema/JsonSchema.cs",
    "FileChanges": [
      {
        "LineNumber": 374,
        "CharNumber": 31,
        "DiagnosticId": "CS0618",
        "FormatDescription": "warning CS0618: \u0027JsonSchema.OtherData\u0027 is obsolete: \u0027Unrecognized keyword data now appears as UnrecognizedKeyword instances in the Keywords collection.\u0027"
      }
    ]
  },
  {
    "DocumentId": {
      "ProjectId": {
        "Id": "6f73f141-f542-4fed-a100-2fb7c5a93aef"
      },
      "Id": "9eb6c1e4-e417-4b8a-8625-eca14de874fa"
    },
    "FileName": "JsonSchema.cs",
    "FilePath": "/home/runner/work/json-everything/json-everything/JsonSchema/JsonSchema.cs",
    "FileChanges": [
      {
        "LineNumber": 379,
        "CharNumber": 23,
        "DiagnosticId": "CS0618",
        "FormatDescription": "warning CS0618: \u0027JsonSchema.OtherData\u0027 is obsolete: \u0027Unrecognized keyword data now appears as UnrecognizedKeyword instances in the Keywords collection.\u0027"
      }
    ]
  },
  {
    "DocumentId": {
      "ProjectId": {
        "Id": "6f73f141-f542-4fed-a100-2fb7c5a93aef"
      },
      "Id": "9eb6c1e4-e417-4b8a-8625-eca14de874fa"
    },
    "FileName": "JsonSchema.cs",
    "FilePath": "/home/runner/work/json-everything/json-everything/JsonSchema/JsonSchema.cs",
    "FileChanges": [
      {
        "LineNumber": 401,
        "CharNumber": 35,
        "DiagnosticId": "CS0618",
        "FormatDescription": "warning CS0618: \u0027JsonSchema.OtherData\u0027 is obsolete: \u0027Unrecognized keyword data now appears as UnrecognizedKeyword instances in the Keywords collection.\u0027"
      }
    ]
  }
]

@github-actions
Copy link

github-actions bot commented May 26, 2022

Unit Test Results

     10 files       10 suites   6s ⏱️
7 312 tests 7 294 ✔️ 18 💤 0
7 390 runs  7 372 ✔️ 18 💤 0

Results for commit 8c49206.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot added documentation Improvements or additions to documentation json-everything.net labels May 26, 2022
@gregsdennis gregsdennis merged commit bd394a0 into master May 26, 2022
@gregsdennis gregsdennis deleted the schema/unknown-keywords branch May 26, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant