Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON-e #566

Merged
merged 63 commits into from
Nov 28, 2023
Merged

JSON-e #566

merged 63 commits into from
Nov 28, 2023

Conversation

gregsdennis
Copy link
Owner

@gregsdennis gregsdennis commented Nov 24, 2023

Resolves #539
Depends on json-e/json-e#504

There are three tests that involve unicode that I believe are incorrect as they're not properly JSON-escaping the chars. The dependency above is tracking that correction.

Additionally, while I strived to make error messages the same, they're not on about 30 tests. The scenarios still produce errors, as expected, but the message isn't the same. I'm considering this good enough for a first release.

Copy link

github-actions bot commented Nov 24, 2023

Test Results

       15 files  +       1         15 suites  +1   16s ⏱️ ±0s
19 943 tests +1 086  18 568 ✔️ +1 050  1 375 💤 +36  0 ±0 
20 321 runs  +1 092  18 897 ✔️ +1 055  1 424 💤 +37  0 ±0 

Results for commit b65569f. ± Comparison against base commit e59bd91.

This pull request removes 8 and adds 1088 tests. Note that renamed tests count towards both.
    "other string"
    "string",
    42
  "foo": [
  ]
Json.Schema.Tests.CrossDraftTests ‑ ArrayItemsIsAllowedForDraft7({
},False)
},True)
Json.JsonE.Tests.CustomFunctionTests ‑ ModFunction
Json.JsonE.Tests.DevTest ‑ Check
Json.JsonE.Tests.Suite.MoreTestsRunner ‑ $map over object, one var  |  {"$map":{"a":1,"b":2,"c":3},"each(y)":{"${y.key}x":{"$eval":"y.val + 1"}}}  |  {}
Json.JsonE.Tests.Suite.MoreTestsRunner ‑ $map over object, two vars  |  {"$map":{"a":1,"b":2,"c":3},"each(v,k)":{"${k}x":{"$eval":"v + 1"}}}  |  {}
Json.JsonE.Tests.Suite.MoreTestsRunner ‑ $map over object, two vars (overwrite)  |  {"$map":{"a":1,"b":2,"c":3},"each(v,k)":{"foo":{"$eval":"v + 1"}}}  |  {}
Json.JsonE.Tests.Suite.MoreTestsRunner ‑ $sort variable not used (in context)  |  {"$sort":[2,1,3],"by(x)":"foo"}  |  {"foo":1}
Json.JsonE.Tests.Suite.MoreTestsRunner ‑ $sort variable not used (not in context)  |  {"$sort":[2,1,3],"by(x)":"foo"}  |  {}
Json.JsonE.Tests.Suite.MoreTestsRunner ‑ Nested in an object  |  {"key":{"$reverse":[1,2,3]}}  |  {}
Json.JsonE.Tests.Suite.MoreTestsRunner ‑ accessor after function call  |  {"$eval":"split(\"left:right\", \":\")[1]"}  |  {}
Json.JsonE.Tests.Suite.MoreTestsRunner ‑ division with addition  |  {"$eval":"a / 3 + 4"}  |  {"a":12}
…

♻️ This comment has been updated with latest results.

@gregsdennis
Copy link
Owner Author

Going to release as is for now, ignoring the dependency. When that goes through, I'll un-ignore those tests and push an update if necessary.

@gregsdennis gregsdennis merged commit 3f46d41 into master Nov 28, 2023
5 of 6 checks passed
@gregsdennis gregsdennis deleted the json-e branch November 28, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON-e
1 participant