-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON-e #566
JSON-e #566
Conversation
…ng function names; prevent infinite loop in function parse
Test Results 15 files + 1 15 suites +1 16s ⏱️ ±0s Results for commit b65569f. ± Comparison against base commit e59bd91. This pull request removes 8 and adds 1088 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Going to release as is for now, ignoring the dependency. When that goes through, I'll un-ignore those tests and push an update if necessary. |
Resolves #539
Depends on json-e/json-e#504
There are three tests that involve unicode that I believe are incorrect as they're not properly JSON-escaping the chars. The dependency above is tracking that correction.
Additionally, while I strived to make error messages the same, they're not on about 30 tests. The scenarios still produce errors, as expected, but the message isn't the same. I'm considering this good enough for a first release.