Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema/builder extension update #709

Merged
merged 4 commits into from Apr 18, 2024
Merged

Conversation

gregsdennis
Copy link
Owner

@SGStino, your changes will publish with this PR.

Resolves #704

Stijn TALLON and others added 2 commits April 16, 2024 09:38
Copy link

Test Results

    15 files  ±0      15 suites  ±0   11s ⏱️ ±0s
21 041 tests ±0  19 681 ✅ ±0  1 360 💤 ±0  0 ❌ ±0 
21 133 runs  ±0  19 770 ✅ ±0  1 363 💤 ±0  0 ❌ ±0 

Results for commit f0e1db9. ± Comparison against base commit f9e9cab.

This pull request removes 13 and adds 4 tests. Note that renamed tests count towards both.
    "other string"
    "string",
    42
  "foo": 42
  "foo": [
  42
  ]
Json.JsonE.Tests.TruthyTests ‑ IsTruthy([
Json.JsonE.Tests.TruthyTests ‑ IsTruthy({
Json.Schema.Tests.CrossDraftTests ‑ ArrayItemsIsAllowedForDraft7({
…
Json.JsonE.Tests.TruthyTests ‑ IsTruthy([
  42
],True)
Json.JsonE.Tests.TruthyTests ‑ IsTruthy({
  "foo": 42
},True)
Json.Schema.Tests.CrossDraftTests ‑ ArrayItemsIsAllowedForDraft7({
  "foo": [
    "string",
    "other string"
  ]
},False)
Json.Schema.Tests.CrossDraftTests ‑ ArrayItemsIsAllowedForDraft7({
  "foo": [
    "string",
    42
  ]
},True)

@gregsdennis gregsdennis merged commit 5a9c156 into master Apr 18, 2024
6 checks passed
@gregsdennis gregsdennis deleted the schema/builder-extension-update branch April 18, 2024 03:08
@gregsdennis
Copy link
Owner Author

Seems this broke things. Reverting. Will include in next major version.

@SGStino
Copy link

SGStino commented Apr 24, 2024

It broke the binary compatibility as you predicted?

@gregsdennis
Copy link
Owner Author

Yep. You can still cast them to IReadOnlyList<T>. It's a little cruft in your code, but it'll work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibly wrong return type
2 participants