Do not evaluate untaken if and switch branches #714
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #713
The samples for json-e indicate that one can check for an value in an if statement and attempt to use it in the 'then' block.
This change delays evaluating the 'then' and 'else' blocks until they are needed, and a similar change is applied to the 'switch' statement.
The change for
IfThenElseOperator
is fairly straightforward. TheSwitchOperator
one was as well, although it does change the order from:JsonE.Evaluate(parameter, context)!.AsObject();
)to:
JsonE.Evaluate
! Not sure if this is important. I saw one code path that looked like it might unescape keys or impact it another way. Please review carefully.)It passed all the tests still, but I am not super comfortable that I changed the order above. I'm hoping you know (or have any easy way to check) if that's problematic.