Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable ref types (and some schema things) #75

Merged
merged 17 commits into from Feb 24, 2021
Merged

Conversation

gregsdennis
Copy link
Owner

@gregsdennis gregsdennis commented Feb 22, 2021

Resolves #76

@github-actions
Copy link

This is a sanity check that indicates whether the change is more severe than intended. It is not foolproof as not all changes can be detected by analyzing the public interface of an assembly. Therefore the results of this check are to be considered as a suggestion. You may determine that a particular change warrants a more severe version bump than is suggested by this check.

Please use your best judgment when updating the version. You know your change better than this check can.

Summary

Actual new version: 1.0.1 (Patch)
Suggested new version: 1.0.0 (None).

@github-actions
Copy link

This is a sanity check that indicates whether the change is more severe than intended. It is not foolproof as not all changes can be detected by analyzing the public interface of an assembly. Therefore the results of this check are to be considered as a suggestion. You may determine that a particular change warrants a more severe version bump than is suggested by this check.

Please use your best judgment when updating the version. You know your change better than this check can.

Summary

Actual new version: 1.3.1 (Patch)
Suggested new version: 1.3.0 (None).

@github-actions

This comment has been minimized.

@github-actions
Copy link

This is a sanity check that indicates whether the change is more severe than intended. It is not foolproof as not all changes can be detected by analyzing the public interface of an assembly. Therefore the results of this check are to be considered as a suggestion. You may determine that a particular change warrants a more severe version bump than is suggested by this check.

Please use your best judgment when updating the version. You know your change better than this check can.

Summary

Actual new version: 1.2.1 (Patch)
Suggested new version: 1.2.0 (None).

@github-actions
Copy link

This is a sanity check that indicates whether the change is more severe than intended. It is not foolproof as not all changes can be detected by analyzing the public interface of an assembly. Therefore the results of this check are to be considered as a suggestion. You may determine that a particular change warrants a more severe version bump than is suggested by this check.

Please use your best judgment when updating the version. You know your change better than this check can.

Summary

Actual new version: 0.1.5 (Patch)
Suggested new version: 0.1.4 (None).

@github-actions
Copy link

This is a sanity check that indicates whether the change is more severe than intended. It is not foolproof as not all changes can be detected by analyzing the public interface of an assembly. Therefore the results of this check are to be considered as a suggestion. You may determine that a particular change warrants a more severe version bump than is suggested by this check.

Please use your best judgment when updating the version. You know your change better than this check can.

Summary

Actual new version: 1.8.1 (Patch)
Suggested new version: 1.8.0 (None).

@github-actions
Copy link

This is a sanity check that indicates whether the change is more severe than intended. It is not foolproof as not all changes can be detected by analyzing the public interface of an assembly. Therefore the results of this check are to be considered as a suggestion. You may determine that a particular change warrants a more severe version bump than is suggested by this check.

Please use your best judgment when updating the version. You know your change better than this check can.

Summary

Actual new version: 1.2.1 (Patch)
Suggested new version: 1.3.0 (Minor).

Details

  • (Minor) AnyOfIntent.Equals(AnyOfIntent, Object) is new or has been made accessible.
  • (Minor) AnyOfIntent.GetHashCode(AnyOfIntent) is new or has been made accessible.
  • (Minor) JsonIncludeAttribute is new or has been made accessible.
  • (Minor) JsonNumberHandling is new or has been made accessible.
  • (Minor) JsonNumberHandlingAttribute is new or has been made accessible.
  • (Patch) The updated reference to System.Text.Json@4.0.1 represents a patch bump.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@gregsdennis gregsdennis changed the title Nullable ref types Nullable ref types (and some schema things) Feb 23, 2021
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link

This is a sanity check that indicates whether the change is more severe than intended. It is not foolproof as not all changes can be detected by analyzing the public interface of an assembly. Therefore the results of this check are to be considered as a suggestion. You may determine that a particular change warrants a more severe version bump than is suggested by this check.

Please use your best judgment when updating the version. You know your change better than this check can.

Summary

Actual new version: 1.9.0 (Minor)
Suggested new version: 2.0.0 (Major).

Details

  • (Minor) EnumerableExtensions.GetStringDictionaryHashCode<T>(this IDictionary2)` is new or has been made accessible.
  • (Minor) EnumerableExtensions.GetStringDictionaryHashCode<T>(this IReadOnlyDictionary2)` is new or has been made accessible.
  • (Minor) EnumerableExtensions.GetUnorderedCollectionHashCode<T>(this IEnumerable1)` is new or has been made accessible.
  • (Minor) JsonSchemaBuilderExtensions.RecursiveAnchor(this JsonSchemaBuilder, Boolean) is new or has been made accessible.
  • (Major) JsonSchemaBuilderExtensions.RecursiveAnchor(this JsonSchemaBuilder) is no longer present or accessible.
  • (Minor) RecursiveAnchorKeyword..ctor(RecursiveAnchorKeyword, Boolean) is new or has been made accessible.
  • (Minor) RecursiveAnchorKeyword.Value is new or has been made accessible.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@gregsdennis gregsdennis merged commit 431def1 into master Feb 24, 2021
@gregsdennis gregsdennis deleted the nullable-ref-types branch February 24, 2021 06:18
@github-actions
Copy link

Unit Test Results

       7 files  ±  0         7 suites  ±0   3s ⏱️ ±0s
4 651 tests +42  4 638 ✔️ +42  13 💤 ±0  0 ❌ ±0 
7 884 runs  +77  7 871 ✔️ +77  13 💤 ±0  0 ❌ ±0 

Results for commit 431def1. ± Comparison against base commit eea9ccc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonSchema.GetHashCode isn't consistent on field re-ordering
1 participant