Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: fix MANDIR #2

Merged
merged 1 commit into from
Nov 13, 2023
Merged

make: fix MANDIR #2

merged 1 commit into from
Nov 13, 2023

Conversation

fichtner
Copy link
Contributor

Fixing this should be enough to remove do-install target from the FreeBSD port

Fixing this should be enough to remove do-install target from the FreeBSD port
@grembo grembo merged commit 8d23909 into grembo:master Nov 13, 2023
@grembo
Copy link
Owner

grembo commented Nov 13, 2023

Thanks!

@fichtner fichtner deleted the patch-1 branch November 13, 2023 10:02
@fichtner
Copy link
Contributor Author

fichtner commented Nov 13, 2023

No problem. We are tracking down a regression in 13.2-RELEASE at the moment... still doing triage but I'll let you know what the relevant change in 0.9 is. It wasn't using libpfctl from ports so far so that's good.

@grembo
Copy link
Owner

grembo commented Nov 13, 2023

@fichtner Any specific symptoms to look for/reproduce?

@fichtner
Copy link
Contributor Author

# /usr/local/sbin/pftop -w 1000 -b -v long 9999999999999 | head

On 0.9 the "RULE" column shows "*" but on 0.8_4 it shows the actual rule number (integer).

We tried opnsense/ports@5808f51124d -- same result
We tried opnsense/ports@5a84f7dc9 -- same result

It could still be a subtle change in libpfctl since we follow stable/13 too, but unsure at this point.

@grembo
Copy link
Owner

grembo commented Nov 13, 2023

I tested, as soon as the rule is not 0, it fails. Pretty certain this is an endianness issue, will look into tracking it down and fixing it.

@grembo
Copy link
Owner

grembo commented Nov 13, 2023

Found it, will push a fix soon.

@fichtner
Copy link
Contributor Author

@grembo super, thanks a lot

@grembo
Copy link
Owner

grembo commented Nov 13, 2023

@fichtner released 0.10 and updated the port, can you test?
https://cgit.freebsd.org/ports/commit/?id=18617a0174cc5069611a7f1c37ba9b80feb70a7a

@fichtner
Copy link
Contributor Author

@grembo works fine, thanks for the quick response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants