Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Implementation: Optimizing Directus Components with Merging and Prop Improvements #378

Merged
merged 7 commits into from
Nov 7, 2023

Conversation

Fritsch-Tech
Copy link
Collaborator

@Fritsch-Tech Fritsch-Tech commented Aug 4, 2023

🔧 Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Codebase improvement
  • Other (if none of the other choices apply)

🚨 Checklist

  • I've read the guidelines for contributing
  • I've added necessary documentation (if appropriate)
  • I've ensured that my code additions do not fail linting or unit tests (if applicable)
    Title: "Code Implementation: Optimizing Directus Components with Merging and Prop Improvements"

Description

This pull request implements the proposal discussed in discussion #370 .

The following changes have been made:

  1. Merging Directus Components: DirectusAsset and DirectusImage components have been merged into a single DirectusFiles component. This consolidation aims to improve code organization and maintainability.

  2. Prop Improvements: To simplify transformations, I have introduced a new Directus Transformation prop that accepts either a preset or a custom transformation (of type string | CustomTransformations). I also added the filname prop. We are now on par with the directus API.

I believe these changes maintain full backward compatibility, but I would like to seek your opinion before proceeding. Before merging, test cases will need to be written and thoroughly evaluated to ensure the changes function as expected.

Please review the changes and provide your valuable feedback.

Thank you for considering this pull request, and I look forward to your input before proceeding further!

😊

@Fritsch-Tech Fritsch-Tech changed the title Code Improvement: Changed AuthStates Type from Union to Enum Code Implementation: Optimizing Directus Components with Merging and Prop Improvements Aug 4, 2023
@Fritsch-Tech Fritsch-Tech merged commit 0c8fdff into gremo:main Nov 7, 2023
@Fritsch-Tech Fritsch-Tech deleted the merge-components branch November 7, 2023 04:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants