Skip to content

Commit

Permalink
[runtime] Downgrade some typemap message severity
Browse files Browse the repository at this point in the history
Context: xamarin#4791

Make a couple of messages related to MVID use `log_info` instead of
`log_warn` so that they are not shown by default (even though they are
useful for diagnostic purposes)
  • Loading branch information
grendello committed Jun 17, 2020
1 parent d9a0325 commit be5f044
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/monodroid/jni/embedded-assemblies.cc
Expand Up @@ -295,7 +295,7 @@ EmbeddedAssemblies::typemap_java_to_managed (const char *java_type_name)

MonoType *type = mono_reflection_type_from_name (const_cast<char*>(managed_type_name), nullptr);
if (XA_UNLIKELY (type == nullptr)) {
log_warn (LOG_ASSEMBLY, "typemap: managed type '%s' (mapped from Java type '%s') could not be loaded", managed_type_name, java_type_name);
log_info (LOG_ASSEMBLY, "typemap: managed type '%s' (mapped from Java type '%s') could not be loaded", managed_type_name, java_type_name);
return nullptr;
}

Expand Down Expand Up @@ -505,7 +505,7 @@ EmbeddedAssemblies::typemap_managed_to_java ([[maybe_unused]] MonoType *type, Mo

const TypeMapModule *match = binary_search<uint8_t, TypeMapModule, compare_mvid> (mvid, map, map_entry_count);
if (match == nullptr) {
log_warn (LOG_ASSEMBLY, "typemap: module matching MVID [%s] not found.", MonoGuidString (mvid).get ());
log_info (LOG_ASSEMBLY, "typemap: module matching MVID [%s] not found.", MonoGuidString (mvid).get ());
return nullptr;
}

Expand Down

0 comments on commit be5f044

Please sign in to comment.