-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] allow custom block to specify which mouse button to use when clicking #90
Conversation
Thanks! I will check it in the next few days. |
Hi I am not sure how to enable on_left_click I tried to add on_left_click = "something" but that does not work |
@endir i made it a bit different, not sure about the syntax in toml but the rust would be |
that way we could do all supported click types, i didnt test how to input it however.... I'll see about doing some research if you cant find it |
I'll check it out soon, thanks :D |
updated this back to master now that I have more time, I'll look into getting this working properly in the coming days |
Ok, this version should be testable, however I don't know if we want the config to work in the way it does for this block. Currently to use the specific mouse buttons the user would have something like this in the config.toml: theme = "solarized-dark"
icons = "awesome"
[[block]]
block = "custom"
[[block.on_set_clicks]]
button = 1
action = "echo LeftClick"
[[block.on_set_clicks]]
button = 2
action = "echo MiddleClick" The names are not the best, but I can't think of something better, for now the |
Signed-off-by: Victor M. Suarez <svmnotn@gmail.com>
Signed-off-by: Victor M. Suarez <svmnotn@gmail.com>
@svmnotn Sorry for taking so long to get to this! Are you still using/interested in implementing this feature? If so, can we do it without breaking existing user configs? |
Closing due to inactivity. |
I haven't tested it. @endir could you please see if this could fix #89? This is mostly a proof of concept, so it needs testing but since it compiles, theoretically it should work but who knows.
I'm open to any recommendations on how to do this in a better, more user friendly manner.
However if it's anything related to reading the mouse button name, it would be nice if @pitkley could extend the deserialize impl to handle it ;)