Adding window state keeper #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafuga
force-pushed
the
Adding_window_state_keeper
branch
from
8b3f659
to
3683e79
Compare
dafuga
commented
May 24, 2018
| @@ -193,7 +193,6 @@ | |||
| "i18next-electron-language-detector": "^0.0.10", | |||
| "i18next-sprintf-postprocessor": "^0.2.2", | |||
| "i18next-sync-fs-backend": "^1.0.0", | |||
| "npm": "^5.7.1", | |||
There was a problem hiding this comment.
Removed this since it was causing a post-install script to fail.
There was a problem hiding this comment.
Yeah - strange. It's still working though!
Storing window attributes and using them on electron app startup.
dafuga
force-pushed
the
Adding_window_state_keeper
branch
from
3683e79
to
32ecb09
Compare
dafuga
commented
May 24, 2018
| @@ -97,18 +97,11 @@ JSONStream@^0.8.4: | |||
| jsonparse "0.0.5" | |||
| through ">=2.2.7 <3" | |||
|
|
|||
| JSONStream@^1.3.2: | |||
There was a problem hiding this comment.
Not sure why all of these dependencies got changed when I ran 'yarn install', but can you try this setup and see if it works for you?
|
Looks good - works well, going to merge it in, then deal with merging my last couple days work in. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing window attributes and using those on app startup.