Deadlock fixes #708
Merged
Deadlock fixes #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denravonska
force-pushed
the
deadlock-fixes
branch
from
f16119d
to
0da4d51
Compare
|
good find. |
|
Possible Win freeze fix. Revert if necessary. |
denravonska
added a commit
to denravonska/Gridcoin-Research
that referenced
this pull request
Feb 21, 2018
This order is still used in blackcoin. Any order which violates this is a new regression introduced in Gridcoin and should be changed. The cs_main scope has also been reduced which fixes the RPC and UI slowdowns when syncing.
denravonska
added a commit
that referenced
this pull request
Feb 23, 2018
Revert lock order from #708.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State: Testable
Fix two lock order issues which are very likely to result in deadlocks. Will try to fix one more issue where the lock fails after receiving the initial block burst.
Large diff is due to level differences. Diff with
?w=1: https://github.com/gridcoin/Gridcoin-Research/pull/708/files?w=1