[JFG-833] New implementation of RPS load with periodic workload process. #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PerThreadWorkloadProcess remains the same (not using AbstractWorkloadProcess) by purpose. |
amikryukov
force-pushed
the
playaround
branch
from
d6624c6
to
4bf9c72
Compare
…orkload services done.
| this(DEFAULT_CORE_POOL_SIZE); | ||
| } | ||
|
|
||
| public PeriodSingleTaskScheduler(int corePoolSize) { |
There was a problem hiding this comment.
for what purposes you need corePoolSize ?
amikryukov
added a commit
that referenced
this pull request
May 28, 2015
New implementation of RPS load with periodic workload process.
| // wait till execution stops | ||
| lfs.get(); | ||
| } catch (InterruptedException e) { | ||
| e.printStackTrace(); |
|
any tests? schema changes? |
|
There is one new test in smokes, and there are more tests in separate repo : https://github.com/amikryukov/qps-test-temporary |
|
is new test uses periodic workload? |
|
Yes - actually now, all tests that uses "rps-load" - uses periodic workload, as from now on "rps-load" is parsed as new clock configuration, witch send "period" in configuration to Kernels(Workers) while ticking. And that is the way workload branch is choosing: if (command.getScenarioContext().getWorkloadConfiguration().getPeriod() > 0) { |
dlatnikov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invocations starts with calculated period.
If thread pull is full (not enough threads to provide specified rps) - WARN message occurs.