Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GG-17466 Fix failing web console e2e tests #15

Closed
wants to merge 2 commits into from
Closed

GG-17466 Fix failing web console e2e tests #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37f3b8a
GG-17466 Fix selector.
Apr 29, 2019
04fc38f
GG-17466 Modify basic config test to match assertion comment.
Apr 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/web-console/e2e/testcafe/components/FormField.js
View file
Open in desktop
Expand Up @@ -51,7 +51,7 @@ export class FormField {
async selectOption(label) {
await t
.click(this.control)
.click(Selector('.bssm-item-button').withText(label));
.click(this.control.find('option').withText(label));
}
/**
* Get error element by error type
Expand Down
6 changes: 3 additions & 3 deletions modules/web-console/e2e/testcafe/fixtures/configuration/basic.js
View file
Open in desktop
Expand Up @@ -56,7 +56,7 @@ test('Basic editing', async(t) => {
const page = new PageConfigurationBasic();
const clusterName = 'Test basic cluster #1';
const localMode = 'LOCAL';
const atomic = 'ATOMIC';
const transactional = 'TRANSACTIONAL';

await t
.expect(page.buttonPreviewProject.visible).notOk('Preview project button is hidden for new cluster configs')
Expand All @@ -69,12 +69,12 @@ test('Basic editing', async(t) => {
await cache1.startEdit();
await t.typeText(cache1.fields.name.control, 'Foobar');
await cache1.fields.cacheMode.selectOption(localMode);
await cache1.fields.atomicityMode.selectOption(atomic);
await cache1.fields.atomicityMode.selectOption(transactional);
await cache1.stopEdit();

await t.expect(cache1.getItemViewColumn(0).textContent).contains(`Cache1Foobar`, 'Can edit cache name');
await t.expect(cache1.getItemViewColumn(1).textContent).eql(localMode, 'Can edit cache mode');
await t.expect(cache1.getItemViewColumn(2).textContent).eql(atomic, 'Can edit cache atomicity');
await t.expect(cache1.getItemViewColumn(2).textContent).eql(transactional, 'Can edit cache atomicity');

await page.save();
await t
Expand Down