-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): 🐞 pre-commit config checks and pip shim fix #248
fix(ci): 🐞 pre-commit config checks and pip shim fix #248
Conversation
Let's add some real ruff rules and re-check all
Now we can see actual problem of shell usages too. Also we need to handle noqa in a better way |
70 errors left
|
I also ignore both of this for know but we need better exception handle and change that string nvautoinstall/operations/handle_prime_support.py:29:33: ISC003 Explicitly concatenated string should be implicitly concatenated |
These are the ignored list
For now pre-commit passes I also used experimental black string processing ability to handle those long lines. It looks okay but may need a tiny test other than me as well. |
Last status and isort removed yes because ruff handles that too.
|
cc @t0xic0der we can also remove this sections from toml file because we have different rule with ruff or we can do more adjustment we should stick to using one
|
|
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Onuralp SEZER <thunderbirdtr@fedoraproject.org>
fix(ci): 🐞 formatter check from toml with pytest removed and __all__ added
225cc82
to
aaccd94
Compare
Signed-off-by: Onuralp SEZER <thunderbirdtr@fedoraproject.org>
cc @t0xic0der all fixed and conflicts are resolved as well. CI also passed too (our check CI gonna be replace with pre-commit bot so this is okay) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Fixes #246
I also found that there was a bug related to pre-commit and after a little bit of search I upgrade all pre-commit tools so now this one not showing up.
Previously error looks like this