-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add simple midi support with the synth keys #59
Conversation
Just curious - why was this closed? Seems like a cool feature. |
It has been closed accidentally.. but the reason why i didn't merge it yet is because i can't test it right now, i don't have any keyboard for the moment and i can't push code without testing it. But the code is still compatible with the current codebase (the PR contains diff code to ignore on the |
I can check if the code still works with the codebase. This PR is more a proof of concept. If you want to improve it and change it, I really don't mind and also I am not too familiar with js frontend dev and your project code. |
Cool; thanks - that's what I suspected. I'm a big MIDI fan, so I was looking forward to trying this out. Indeed, now that I know the proposal's not dead, I'll feel free to try it out. Very cool project, by the way! |
@mr21 can you give me advice on how to separate the between your different repos for this project like backend(daw)/frontend(gs-ui-components) and where to put the midi logic. |
Hi @antoinebou13, glad you still here, sorry the development is really slow..
But yes we could imagine the need to make some change into the (There are also some utils and assets repo i didn't talk about) thx for your interest @antoinebou13 and @noodnik2 |
I added a simple popup menu to control the midi devices with that you can control the synth piano roll.
I need to move the business logic outside the UI logic like (parseMidiMessage, parseMidiMessage)
Outside the scope of the PR
I added in the build.sh options
- server: add a node js to serve the index.html/index-prod.html file
- help: show the available command