-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alwaysShowResizeHandle does not work anymore in v2.0.0 #1373
Comments
I'm not seeing this issue on Chrome/Windows 10. please provide what browser and with 1.21.1 vs 2.0.0 as maybe your browser doesn't support these var grid = GridStack.init({
alwaysShowResizeHandle: /Android|webOS|iPhone|iPad|iPod|BlackBerry|IEMobile|Opera Mini/i.test(
navigator.userAgent
),
resizable: {
handles: 'e, se, s, sw, w'
}, |
BTW, I am using the latest version of Chrome (85.0.4183.121) on the latest version of Windows 10. I already explicitly stated that I was using Gridstack 2.0.0 and that the issue applies to all browsers. |
Please re-read your bug report. You said "alwaysShowResizeHandle does not work anymore" then you point to my example which does show the resize handles in all corners as stated in the code, while other demos do show on hover only (don't have that flag turned on). You didn't bother copying the bug template and modifying to show an actual bug, but expect me to debug it for you ??? then in your later comment you say "In my screenshot, I circled all resize handles which should NOT be visible, unless HOVERED." then you must be turning that feature off - how am I supposed to know what you mean ? | I will think twice now before reporting another issue. what do you expect ? this is a free lib and I didn't see you contribute time or $ (there is a donate button in case you missed it). I spent a LOT of personal time maintaining this lib and you didn't file a reproduceable bug. Thank you for taking 20min of my time this morning debugging it for you twice now. Note to self: apparently this flag define IF the handles are always visible or not, instead of resizable: { handles: 'e, se, s, sw, w' } |
* fix for gridstack#1373 * Utils.defaults() now works recursively which was causing sub items to not e init properly. * also cleaned up some signature calls to TS standards * you can now have resize handles and still auto-hide them.
fixed in next release |
Thanks! |
* fix for gridstack#1373 * Utils.defaults() now works recursively which was causing sub items to not e init properly. * also cleaned up some signature calls to TS standards * you can now have resize handles and still auto-hide them.
Subject of the issue
Since v2.0.0, the option alwaysShowResizeHandle does not work anymore. I looked up the code and assume this functionality has been deleted when JQuery (UI) was deleted from the codebase.
Your environment
Steps to reproduce
This also occurs in your own demos. The easiest way to reproduce is to open own of your own examples using this option, like the advanced demo.
Expected behaviour
Auto hide of resize handles should work.
Actual behaviour
Auto hide of resize handles does not work, handles are always being shown.
The text was updated successfully, but these errors were encountered: