Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4: removable:true not working #1760

Closed
adumesny opened this issue May 23, 2021 · 0 comments · Fixed by #1762 or #1763
Closed

v4: removable:true not working #1760

adumesny opened this issue May 23, 2021 · 0 comments · Fixed by #1762 or #1763

Comments

@adumesny
Copy link
Member

adumesny commented May 23, 2021 •
edited

Subject of the issue

looks like I broke removeable:true options when I re-wrote drag&drop (works ok with class name which all demos use).

Your environment

  • 4.2.3 win10 chrome

Steps to reproduce

spec/e2e/html/1570_drag_bottom_max_row.html

Expected behavior

remove when leaving the grid
@adumesny adumesny changed the title v4: removable: true not working v4: removable:true not working May 23, 2021
adumesny added a commit to adumesny/gridstack.js that referenced this issue May 24, 2021
@adumesny
removable:true working again (broke in 4.x)
189ab15 
* fix gridstack#1760
adumesny added a commit to adumesny/gridstack.js that referenced this issue May 24, 2021
@adumesny
removable:true working again (broke in 4.x)
6d5d4dc 
* fix gridstack#1760
@adumesny adumesny mentioned this issue May 24, 2021
Merged
3 tasks
adumesny added a commit to adumesny/gridstack.js that referenced this issue May 25, 2021
@adumesny
Toggling staticGrid allows dragging in again
3e430d0 
fix gridstack#1761
* we now re-enable the drag enter events when staticGrid is false
* updated static demo to show drag in behavior as well.

fix gridstack#1760 failing to check for null element in my last check-in.
@adumesny adumesny mentioned this issue May 25, 2021
Merged
3 tasks
@adumesny adumesny mentioned this issue Jun 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@adumesny