Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removable true doesnt work #1784

Closed
qbunia opened this issue Jun 11, 2021 · 4 comments · Fixed by #1787
Closed

Removable true doesnt work #1784

qbunia opened this issue Jun 11, 2021 · 4 comments · Fixed by #1787

Comments

@qbunia
Copy link

qbunia commented Jun 11, 2021

Subject of the issue

I set removable to true and when moving item outside grid the item is not removed.

Your environment

  • gridstack v4.2.4
  • firefox, windows 10

Steps to reproduce

https://jsfiddle.net/3nazp2Lb/3/

Expected behavior

Item is removed when dragged outside grid

Actual behavior

Item is not removed

@qbunia qbunia changed the title Removable true doenst work Removable true doesnt work Jun 11, 2021
@adumesny
Copy link
Member

adumesny commented Jun 12, 2021

weird, because I thought I fix it in #1760.

Update: you also need acceptWidgets: true to receive widgets.
Are you wanting to only remove but not add widgets ? seem like odd case, but could separate them I suppose...

adumesny added a commit to adumesny/gridstack.js that referenced this issue Jun 13, 2021
fix gridstack#1784
* removable by itself (without acceptWidgets:true) will now you remove items by dragging them out.
@adumesny
Copy link
Member

fixed in next release. don't forget to donate if you find this lib useful!

@qbunia
Copy link
Author

qbunia commented Aug 5, 2021

Thanks, just sent money. Paypal is horrible, It cost me like 6$ to send money to paypayl. Then Paypal charged me with bad conversion rate of currencies. Then Paypal took around 3$ to send you money. I think it would be cheapier if you would have cryptocurrency option enabled.

@adumesny
Copy link
Member

adumesny commented Aug 7, 2021

thank you. I don't use cryptocurrency (too volatile) but maybe there is another cheaper service (I use venmo for that reason as well, but US only ?) that works better in other parts of the world as many customers seems to be in Europe or Asia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants