Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Invalid height" error when inside flex container after updating 9.2.0 -> 9.2.1 #2469

Closed
elwynelwyn opened this issue Sep 26, 2023 · 2 comments · Fixed by #2471
Closed

"Invalid height" error when inside flex container after updating 9.2.0 -> 9.2.1 #2469

elwynelwyn opened this issue Sep 26, 2023 · 2 comments · Fixed by #2471

Comments

@elwynelwyn
Copy link

elwynelwyn commented Sep 26, 2023

"Invalid height" error when inside flex container after updating 9.2.0 -> 9.2.1

After applying update to 9.2.1 (from 9.2.0) in our project, we started getting a crash when initialising the dashboard.

Uncaught Error: Invalid height

It seems a value of 'auto' is being passed to parseHeight, which fails to match the regex, which is only looking for specific height values.

After a little digging, this seems to happen when the gridstack element is inside a flex container, which is how we're laying things out in our application.

Your environment

  • 9.2.1
  • Chrome 117.0.5938.92, Debian

Steps to reproduce

https://jsfiddle.net/qnx6pwL1/

(view devtools console)

Expected behavior

Dashboard should behave like it did in 9.2.0, rendering correctly and not crashing out.

@Jopie01
Copy link

Jopie01 commented Sep 27, 2023

Since PR #2464 you must have min-height in your CSS for the .grid-stack class.

@adumesny
Copy link
Member

yeah I made that change (back to what is always was) as my app needs to set min-height in CSS rather than minRow, but this shoudl work. will check the broken example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants