Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Invalid height" issue in Jest after 9.2.1 update #2497

Closed
evgeniyefimov opened this issue Oct 10, 2023 · 5 comments · Fixed by #2518
Closed

"Invalid height" issue in Jest after 9.2.1 update #2497

evgeniyefimov opened this issue Oct 10, 2023 · 5 comments · Fixed by #2518
Labels
type:bug

Comments

@evgeniyefimov
Copy link

evgeniyefimov commented Oct 10, 2023 •
edited by adumesny

Subject of the issue

After upgrading gridstack from version 9.2.0 to 9.3 "Invalid height" issue started throwing when we try to detect changes for our component in our spec file. It was working fine before 9.2.1 update.

Your environment

  • version of gridstack.js - 9.3.0
  • which browser/OS - Chrome, Windows 10, NodeJS 18.15, npm 9.4

Steps to reproduce

https://github.com/evgeniyefimov/gridstack_tests_issue
Just run tests. And you will see an issue on line fixture.detectChanges(); with this error.

Expected behavior

Should work fine as it was before 9.3.0
@adumesny
Copy link
Member

@VincentMolinie another one for you...

@adumesny adumesny mentioned this issue Oct 14, 2023
Closed
3 tasks
adumesny added a commit to adumesny/gridstack.js that referenced this issue Oct 15, 2023
@adumesny
Revert "fix(drag): always put element under the mouse when dragging a…
f7c9b10 
…n element (gridstack#2263)"

re-opens gridstack#1275, and fix gridstack#2498 gridstack#2497 gridstack#2491

This reverts commit b559a6f.
@adumesny adumesny mentioned this issue Oct 15, 2023
Merged
3 tasks
adumesny added a commit to adumesny/gridstack.js that referenced this issue Oct 15, 2023
@adumesny
Revert "fix(drag): always put element under the mouse when dragging a…
537344c 
…n element (gridstack#2263)"

re-opens gridstack#1275, and fix gridstack#2498 gridstack#2497 gridstack#2491

This reverts commit b559a6f.
@VincentMolinie
Copy link
Contributor

VincentMolinie commented Oct 16, 2023 •
edited

This one seems relted to this one: #2469. I don't see how it is linked to my code 🤔.
The issue is thrown because min-height is equal to "" (empty string). I didn't change anything on that part 🤔

@adumesny
Copy link
Member

adumesny commented Oct 16, 2023 •
edited

@evgeniyefimov can you verify when this actually started showing up ? (i.e. 9.2.2, 9.2.1, etc..) so we can narrow it down - I don't have time to debug it right now.
@VincentMolinie you may be right, the title I assumed it was 9.3 only (only your changes)

@adumesny adumesny reopened this Oct 16, 2023
@evgeniyefimov
Copy link
Author

@adumesny
9.2.0 works fine
image

looks, like the issue is in 9.2.1
image

I upgraded my Gridstack from 9.2.0 directly to 9.3.0, so I was thinking that the issue is in the 9.3.0. Sorry.

@adumesny adumesny changed the title "Invalid height" issue in Jest after 9.3.0 update "Invalid height" issue in Jest after 9.2.1 update Oct 16, 2023
adumesny added a commit to adumesny/gridstack.js that referenced this issue Oct 23, 2023
@adumesny
parseHeight() fix
0692ced 
* fix gridstack#2497
* make sure to check for height=''
@adumesny adumesny mentioned this issue Oct 23, 2023
Merged
3 tasks
@adumesny
Copy link
Member

@evgeniyefimov next time please including the callstack to I don't have to pull in your change, yarn install and run the test myself (big time sync).
And don't forget to donate if you find this lib useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

parseHeight() fix adumesny/gridstack.js
3 participants
@VincentMolinie @adumesny @evgeniyefimov