Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation issue after upgraded to 9.3.0 #2498

Closed
nhannv opened this issue Oct 11, 2023 · 2 comments · Fixed by #2504
Closed

Animation issue after upgraded to 9.3.0 #2498

nhannv opened this issue Oct 11, 2023 · 2 comments · Fixed by #2504
Labels

Comments

@nhannv
Copy link

nhannv commented Oct 11, 2023

Subject of the issue

I got the drag animation issue (I'm using framer-motion) after upgraded to 9.3.0, the issue also can be reproduced in gridstack's animation example which is using AniJS

Your environment

  • version of gridstack.js - 9.3.0
  • which browser/OS - MacOS

Steps to reproduce

The issue is occurring on Gridstack's animation example: https://gridstackjs.com/demo/anijs.html

Expected behavior

It should smoothly when drag item.

@adumesny
Copy link
Member

adumesny commented Oct 11, 2023

@nhannv I'm opretty sure this worked in 9.2 ? if so another one for @VincentMolinie to take a look.

Vicent at this point (and drag offset not correct fix) I'm tempted to revert back mouse dragging as we're having so many problem with your new code Vincent, and the review itself took a lot of try. I don't want to test everything that can happen. instead you should have added scale to the existing code instead of trowing it all away...

@nhannv
Copy link
Author

nhannv commented Oct 12, 2023

@adumesny Yes, I can confirm the version 9.2.2 works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants