Fixed hang issue when search icon not loaded #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If, during the loading of the icon for the search provider the icon couldn't be loaded (eg. download timeout) the system would hang after loading the search results because each time the result table would go to display a result it would attempt to reload the icon from the search provider. In the case (well, for me anyway) themoviedb/favicon.ico would timeout when loading every time I attempted to interact with the loaded list it would attempt a re-load of the icon. This could be smarter (e.g. after the current operation queue has completed reset the icon to blank and attempt a reload) however in its current form it solves a problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If, during the loading of the icon for the search provider
the icon couldn't be loaded (eg. download timeout)
the system would hang after loading the search results
because each time the result table would go to display
a result it would attempt to reload the icon from the
search provider. In the case (well, for me anyway)
themoviedb/favicon.ico would timeout when loading
every time I attempted to interact with the loaded list
it would attempt a re-load of the icon, which would
continue to fail ad-finitum.
This could be smarter (e.g. after the current operation
queue has completed reset the icon to blank and attempt
a reload) however in its current form it solves a problem