Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Subprojects to newest stable Version. #841

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

MtoLStoN
Copy link
Member

@MtoLStoN MtoLStoN commented Aug 1, 2023

Closes #840.

Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
@bjoe2k4
Copy link

bjoe2k4 commented Aug 2, 2023

I've tested this on our hpc cluster (ubuntu 20.04/intel 2023.1) and it works well.

Only downside are flaky toml-f/tftest-* tests when tests are not limited to xtb only (run tests without --suite xtb). These test fails (usually just one) occur randomly when tests are run multiple times, more likely when test concurrency is increased. If i recall correctly i had this problem already with v6.6.0 but I didn't take it serious.

@awvwgk
Copy link
Member

awvwgk commented Aug 2, 2023

Only downside are flaky toml-f/tftest-* tests when tests are not limited to xtb only (run tests without --suite xtb). These test fails (usually just one) occur randomly when tests are run multiple times, more likely when test concurrency is increased. If i recall correctly i had this problem already with v6.6.0 but I didn't take it serious.

Could you report the flaky tests in TOML Fortran? https://github.com/toml-f/toml-f/issues/new/choose

@MtoLStoN MtoLStoN added this to the v6.7.0 milestone Aug 2, 2023
@bjoe2k4
Copy link

bjoe2k4 commented Aug 2, 2023

Unfortunately i cannot reproduce these flaky tests with standalone toml-f, otherwise i would have reported it upstream. Not sure how to continue from here.

@MtoLStoN
Copy link
Member Author

MtoLStoN commented Aug 2, 2023

While these flaky tests are definitely something we should look at, I can also partly reproduce them with the "old" toml-f version. However, as of now, I could not see any downside except these flaky tests. Interestingly, it seems, that these hiccups only happen with the Intel Fortran Compiler and not with gfortran.

Therefore, I believe it is safe to disregard these failing tests for the time being.

Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
@MtoLStoN MtoLStoN merged commit 31b6daf into main Aug 16, 2023
21 checks passed
@MtoLStoN MtoLStoN deleted the Update_Subprojects branch August 16, 2023 08:23
gorges97 pushed a commit to gorges97/xtb that referenced this pull request Mar 27, 2024
Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
Signed-off-by: Johannes Gorges <58849467+gorges97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dirty source release v6.6.1
3 participants