Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dirty source release v6.6.1 #840

Closed
bjoe2k4 opened this issue Aug 1, 2023 · 1 comment · Fixed by #841
Closed

Dirty source release v6.6.1 #840

bjoe2k4 opened this issue Aug 1, 2023 · 1 comment · Fixed by #841
Labels
build Build system related issues (OS, compilers, meson)

Comments

@bjoe2k4
Copy link

bjoe2k4 commented Aug 1, 2023

Not a bug with the code, so i deleted the Issue template.

  1. The source release has pre-populated subprojects and a superfluous .git folder. The previous releases did not.
  2. The source release references a subproject version subprojects/*.wrap newer than in the git repo (toml-f v0.4.1, but git HEAD still has v0.2.3) .
  3. some subprojects could be updated (test-drive v0.3.0 -> v0.4.0; s-dftd3 v0.6.0 -> v1.0.0; dft-d4 v3.4.0 -> v3.5.0).

Intentional or oversight?

@bjoe2k4 bjoe2k4 added the unconfirmed This report has not yet been confirmed by the developers label Aug 1, 2023
@MtoLStoN
Copy link
Member

MtoLStoN commented Aug 1, 2023

Thank you for bringing this to my attention and reporting it. You were correct in identifying an oversight. I replaced the source release with a new and clean one. Additionally, I will prepare a PR to update the subprojects to ensure everything is up to date.

@MtoLStoN MtoLStoN added build Build system related issues (OS, compilers, meson) and removed unconfirmed This report has not yet been confirmed by the developers labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system related issues (OS, compilers, meson)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants