Fix build error "macro names must be identifiers" #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joel Einbinder <joel.einbinder@gmail.com>
JoelEinbinder
force-pushed
the
fix_compile
branch
from
6d9958f
to
668863a
Compare
awvwgk
approved these changes
Feb 12, 2024
|
Thanks for contributing! |
gorges97
pushed a commit
to gorges97/xtb
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Joel Einbinder <joel.einbinder@gmail.com> Signed-off-by: Johannes Gorges <58849467+gorges97@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to compile xtb and it was failing with
I traced it back to this line where an extra -D was being applied to these flags. Maybe this works as is with a different version of cmake? Happy to close this PR if everything is working as intended. But it compiled successfully for me after applying this patch.
cmake=3.22.1
gfortran=11.4.0
gcc=11.4.0
ubuntu=22.04