Add ProxyWebScraperDriver
#886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
vachillo
force-pushed
the
zen_rows_scraper
branch
from
d905715
to
96e8ee6
Compare
dylanholmes
reviewed
Jun 21, 2024
| "js_render=true", | ||
| "premium_proxy=true", | ||
| ] | ||
| proxy_url = f'http://{os.environ["ZENROWS_API_KEY"]}:{"&".join(query_params)}@proxy.zenrows.com:8001' |
There was a problem hiding this comment.
Where did you get this example url from?
From the docs I found, I'd expect this to look something like https://api.zenrows.com/v1/?apikey=YOUR_ZENROWS_API_KEY&url=https%3A%2F%2Fhttpbin.io%2Fanything&premium_proxy=true (from the cURL example)
There was a problem hiding this comment.
this is from the example on the dashboard when you create a free account. i dont see it in the docs though. i figured this would be an easier generic implementation because the actual url to be scraped does not have to change.
collindutter
previously approved these changes
Jun 21, 2024
collindutter
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.