add withdraw support and some bugfix for websocket #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norunners
reviewed
Apr 10, 2022
Comment on lines
+256
to
+263
| authorized := false | ||
| for _, req := range requests { | ||
| if req.IsPrivateChannel() && !s.authorized { | ||
| if req.IsPrivateChannel() && !authorized { | ||
| err := s.auth(conn) | ||
| if err != nil { | ||
| return errors.WithStack(err) | ||
| } | ||
| s.authorized = true | ||
| authorized = true |
There was a problem hiding this comment.
This looks about right, what error was this encountering before?
There was a problem hiding this comment.
auth state is not correct after reconnect.
norunners
reviewed
Apr 10, 2022
|
|
||
| for { | ||
| message := &models.WsResponse{} | ||
| err = conn.ReadJSON(&message) | ||
| if err != nil { | ||
| s.printf("read msg: %v", err) | ||
| s.printf("channel %v read msg: %v", ftxChannel, err) | ||
| if websocket.IsCloseError(err, websocket.CloseNormalClosure) { | ||
| return | ||
| } | ||
| conn, err = s.reconnect(ctx, requests) |
There was a problem hiding this comment.
There's an edge case below which panics if reconnect returns an error, see conn.WriteMessage below.
There was a problem hiding this comment.
Long time since this PR, currently not working on this project, sorry for no time to deal with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.