Skip to content

Commit

Permalink
(core) remove metrics
Browse files Browse the repository at this point in the history
Summary: This removes some old metric code. There's also a user preference dialog that has a single option (whether to allow metrics) this is left in place with a dummy option. It could be ripped out as well, probably.

Test Plan: existing tests pass

Reviewers: dsagal

Reviewed By: dsagal

Differential Revision: https://phab.getgrist.com/D2622
  • Loading branch information
paulfitz committed Sep 29, 2020
1 parent e5b67fe commit 2edf64c
Show file tree
Hide file tree
Showing 12 changed files with 2 additions and 877 deletions.
15 changes: 0 additions & 15 deletions app/common/GristServerAPI.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,26 +8,11 @@ export interface GristServerAPI extends
DocListAPI,
LoginSessionAPI,
BasketClientAPI,
ServerMetricsAPI,
UserAPI,
SharingAPI,
MiscAPI {}


interface ServerMetricsAPI {
/**
* Registers the list of client metric names. The calls to pushClientMetrics() send metric
* values as an array parallel to this list of names.
*/
registerClientMetrics(clientMetricsList: string[]): Promise<void>;

/**
* Sends bucketed client metric data to the server. The .values arrays contain one value for
* each of the registered metric names, as a parallel array.
*/
pushClientMetrics(clientBuckets: Array<{startTime: number, values: number[]}>): Promise<void>;
}

interface UserAPI {
/**
* Gets the Grist configuration from the server.
Expand Down
101 changes: 0 additions & 101 deletions app/common/MetricCollector.js

This file was deleted.

1 change: 0 additions & 1 deletion app/common/UserConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
* Interface for the user's config found in config.json.
*/
export interface UserConfig {
enableMetrics?: boolean;
docListSortBy?: string;
docListSortDir?: number;
features?: ISupportedFeatures;
Expand Down
252 changes: 0 additions & 252 deletions app/common/metricConfig.js

This file was deleted.

Loading

0 comments on commit 2edf64c

Please sign in to comment.