Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let's always use try_umount #263

Closed
adrelanos opened this issue Dec 22, 2023 · 0 comments · Fixed by #264
Closed

let's always use try_umount #263

adrelanos opened this issue Dec 22, 2023 · 0 comments · Fixed by #264

Comments

@adrelanos
Copy link
Contributor

I would like to modify the code to always use the try_umount function. Why? No disadvantages, less, cleaner code, simpler code because no need to check any complex conditions.

Check if there's a mount, if there's not then that's fine, nothing to do, "return 0". Otherwise, try to umount it.

I'll propose a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant