Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File with BOM and not UTF-8 ? #155

Closed
flobee opened this issue Jan 25, 2024 · 3 comments · Fixed by #156
Closed

File with BOM and not UTF-8 ? #155

flobee opened this issue Jan 25, 2024 · 3 comments · Fixed by #156

Comments

@flobee
Copy link

flobee commented Jan 25, 2024

See my hints:
flobee@a9e10c8

downloaded zshrc files from https://grml.org/zsh/ this way:

# IMPORTANT: please note that you might override an existing
# configuration file in the current working directory! =>
wget -O .zshrc https://git.grml.org/f/grml-etc-core/etc/zsh/zshrc

# Optionally also grab the user configration:
# wget -O .zshrc.local  https://git.grml.org/f/grml-etc-core/etc/skel/.zshrc

Edit in kate and kate says: BOM exists and Line 335 (#getanchors) look damaged.
But the browser tell also weired chars.: https://github.dev/grml/grml-etc-core/blob/master/etc/skel/.zshrc#L335C40-L335C47
mika added a commit that referenced this issue Jan 26, 2024
@mika
etc/skel/.zshrc: set file encoding to UTF8
ae34c42 
The file isn't properly encoded and claims to be latin1.
Convert to UTF8 to avoid broken characters in getanchors().

Thanks: flobee for the bug report
Closes: #155
@mika mika mentioned this issue Jan 26, 2024
Merged
@mika
Copy link
Member

mika commented Jan 26, 2024

Ah nice catch, thanks @flobee! What about #156?

@flobee
Copy link
Author

flobee commented Jan 26, 2024

I like #156 ;-)

just saw your sys-admin presentation at media.ccc from '23. you'are talking very fast ... watched at 75% of speed :-D

@flobee flobee closed this as completed Jan 26, 2024
@mika
Copy link
Member

mika commented Jan 29, 2024

@flobee excellent, merged now! :)

Haha 8-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

etc/skel/.zshrc: set file encoding to UTF8 grml/grml-etc-core
2 participants
@mika @flobee