Skip to content

Commit

Permalink
Don't quote $CIFSOPTS for mount.cifs (Closes: #703746).
Browse files Browse the repository at this point in the history
Quoting $CIFSOPTS passed the literal string "-o user=root,password=" to
mount.cifs, killing mount.cifs with a SIGSEGV. Rather, -o should be
properly space delimited by passing $CIFSOPTS unquoted for options to be
parsed correctly.
  • Loading branch information
Andrew Jeffery authored and daniel-baumann committed May 6, 2013
1 parent 10f4622 commit 414e462
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scripts/boot/9990-mount-cifs.sh
Expand Up @@ -10,15 +10,15 @@ do_cifsmount ()
then
if [ -z "${NFSOPTS}" ]
then
CIFSOPTS="-ouser=root,password="
CIFSOPTS="-o user=root,password="
else
CIFSOPTS="-o ${NFSOPTS}"
fi

log_begin_msg "Trying mount.cifs ${NFSROOT} ${mountpoint} ${CIFSOPTS}"
modprobe -q cifs

if mount.cifs "${NFSROOT}" "${mountpoint}" "${CIFSOPTS}"
if mount.cifs "${NFSROOT}" "${mountpoint}" ${CIFSOPTS}
then
rc=0
fi
Expand Down

0 comments on commit 414e462

Please sign in to comment.