Consistently using case instead of if for conditionals in script boil…

…erplate.
grml · Aug 13, 2012 · 4ecca9f · 4ecca9f
1 parent ba42304
commit 4ecca9f
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 16 deletions.
diff --git a/scripts/boot/0110-debug b/scripts/boot/0110-debug
@@ -13,10 +13,15 @@ Debug ()
 		esac
 	done
 
-	if [ "${LIVE_DEBUG}" != "true" ]
-	then
-		return 0
-	fi
+	case "${LIVE_DEBUG}" in
+		true)
+			;;
 
+		*)
+			return 0
+			;;
+	esac
+
+	# Write the trace output
 	set -x
 }
diff --git a/scripts/boot/0120-read-only b/scripts/boot/0120-read-only
@@ -18,10 +18,14 @@ Read_only ()
 		esac
 	done
 
-	if [ "${LIVE_READ_ONLY}" != "true" ]
-	then
-		return 0
-	fi
+	case "${LIVE_READ_ONLY}" in
+		true)
+			;;
+
+		*)
+			return 0
+			;;
+	esac
 
 	# Marking some block devices as read-only to ensure that nothing
 	# gets written as linux still writes to 'only' read-only mounted filesystems.

diff --git a/scripts/boot/3010-verify-checksums b/scripts/boot/3010-verify-checksums
@@ -18,10 +18,14 @@ Verify_checksums ()
 		esac
 	done
 
-	if [ "${LIVE_VERIFY_CHECKSUMS}" != "true" ]
-	then
-		return 0
-	fi
+	case "${LIVE_VERIFY_CHECKSUMS}" in
+		true)
+			;;
+
+		*)
+			return 0
+			;;
+	esac
 
 	_MOUNTPOINT="${1}"
 

diff --git a/scripts/boot/3020-swapon b/scripts/boot/3020-swapon
@@ -18,10 +18,14 @@ Swap ()
 		esac
 	done
 
-	if [ "${LIVE_SWAP}" != "true" ]
-	then
-		return 0
-	fi
+	case "${LIVE_SWAP}" in
+		true)
+			;;
+
+		*)
+			return 0
+			;;
+	esac
 
 	LIVE_SWAP_DEVICES="${LIVE_SWAP_DEVICES:-/dev/sd* /dev/vd*}"