Skip to content

Commit

Permalink
Fixing an incorrectly redirected newline.
Browse files Browse the repository at this point in the history
Since this newline was written to stdout it both messed up the the
display of errors while entering a LUKS passphrase, and caused
find_cow_device to return a bad string under certain
circumstances. Example: You have home-rw on /dev/sdX1. You'll first
be asked for passphrase for "live-rw on /dev/sdX1", which you skip (a
newline has been written to stdout now). Then you're asked for
"home-rw on /dev/sdX1", which is what you want so you enter it.
Thanks to the spurious newline find_cow_device returns "\n/dev/loopY",
which breaks some tests later.
  • Loading branch information
Tails developers authored and daniel-baumann committed Nov 24, 2011
1 parent 959403d commit 544c8db
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/live-helpers
Expand Up @@ -357,7 +357,7 @@ find_cow_device ()
break
fi

echo
echo >&6
echo -n "There was an error decrypting ${devname} ... Retry? [Y/n] " >&6
read answer

Expand Down

0 comments on commit 544c8db

Please sign in to comment.