Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow certificate input via any object that responds to read #13

Merged
merged 1 commit into from Jul 9, 2012

Conversation

kyledrake
Copy link
Contributor

With our implementation, we pass certificates via a call to a remote database. So we don't keep them as files locally, so the File.read approach doesn't work for us without trickery (such as using Tempfile#path).

This allows developers to provide an IO object that responds to #read as well. It's not perfect (a better solution would be to allow the PEM to be passed directly somehow) but it should work for most people I think!

Tests are passing. Let me know if the upstream merge screwed up the pull and I'll re-apply the code without the merge.

@vanstee
Copy link
Member

vanstee commented Jul 8, 2012

Looks good to me. Thoughts @alindeman @stevenharman ?

@kyledrake Do you mind rebasing out that merge bubble?

@alindeman
Copy link
Member

Cool idea! +1 to merge minus the bubble.

@kyledrake
Copy link
Contributor Author

I've never attempted to do a rebase, but I will make an attempt right now.

@vanstee
Copy link
Member

vanstee commented Jul 9, 2012

Something like this should do the trick:

git checkout certificate_string_io
git reset --hard 97ea06b
git pull --rebase upstream master

@kyledrake
Copy link
Contributor Author

Alright, the merge is gone. I think this guy is ready to go!

stevenharman pushed a commit that referenced this pull request Jul 9, 2012
Allow certificate input via any object that responds to read
@stevenharman stevenharman merged commit 9c26c62 into grocer:master Jul 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants