Allow certificate input via any object that responds to read #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With our implementation, we pass certificates via a call to a remote database. So we don't keep them as files locally, so the File.read approach doesn't work for us without trickery (such as using Tempfile#path).
This allows developers to provide an IO object that responds to #read as well. It's not perfect (a better solution would be to allow the PEM to be passed directly somehow) but it should work for most people I think!
Tests are passing. Let me know if the upstream merge screwed up the pull and I'll re-apply the code without the merge.