Purchase factor #423
Closed
Purchase factor #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k_current_location_content
berrnd
requested changes
Oct 19, 2019
There was a problem hiding this comment.
Thanks!
I see the benefit of displaying the stock value of a product on the stock overview page and on the product card - but what's the point about displaying the "purchase to stock factor"?
Code-wise I think this would better fit into ProductDetails, as it's a value per product (and not doing the summarization on frontend JS)...
Also displaying any price information should depend on FEATURE_FLAG_STOCK_PRICE_TRACKING.
|
I'll retake a look at this and close it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Value and Purchase Factor Information