-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue in eeprom.c with PIC registers #2
Comments
Hi David, when I check the history https://github.com/grodansparadis/vscp_firmware/commits/master/pic/common/eeprom.c it looks like it has not been there for at least since 2012, if ever. I have added the suggested change. Please test. /Ake waaslandwolf skrev den 2014-12-30 19:00:
Be Hungry - Stay Foolish! Detta e-postmeddelande har sökts igenom efter virus med antivirusprogram från Avast. |
Ake, For me the change as I proposed below works fine on 18F45K80. Probably Kurt wrote this code for his Hasselt module but it never made it into the main branch. So the kudos go to him J David. From: Ake Hedman [mailto:notifications@github.com] Hi David, when I check the history https://github.com/grodansparadis/vscp_firmware/commits/master/pic/common/eeprom.c it looks like it has not been there for at least since 2012, if ever. I have added the suggested change. Please test. /Ake waaslandwolf skrev den 2014-12-30 19:00:
Be Hungry - Stay Foolish! Detta e-postmeddelande har sökts igenom efter virus med antivirusprogram från Avast. — Dit e-mailbericht is gecontroleerd op virussen met Avast antivirussoftware. |
Ake,
I am just updating my firmware with a git pull I did today. The file eeprom.c throws an error because it does not recognize the register PIR2bits.EEIF. In the old code there was a compiler preprocessor statement that compiled PIR4bits.EEIF for some PICs (like my 18F45K80), and PIR2bits.EEIF for everything else. This seems to have been removed in the latest code on Git. I wonder why, since this seems to break compilation for some PICs. Wouldn't it be better to include it again?
David.
This is the code I'm talking about, in the function writeEEPROM():
...
if defined(__18F25K80) || defined(__18F26K80) || defined(__18F45K80) || defined(__18F46K80) || defined(__18F65K80) || defined(__18F66K80)
else
endif
...
The text was updated successfully, but these errors were encountered: