Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination Support for snipeit #12

Closed
wants to merge 0 commits into from
Closed

Pagination Support for snipeit #12

wants to merge 0 commits into from

Conversation

m4us1ne
Copy link

@m4us1ne m4us1ne commented May 6, 2023

This MR fixes the for me broken model gathering from snipeit. i have over 1k models and this mr makes use of the pagination support in snipeit. i'd like to also introduce a bit of formatting improvments and a switch to fstrings.

@guardrails
Copy link

guardrails bot commented May 6, 2023

⚠️ We detected 1 security issue in this pull request:

Hard-Coded Secrets (1)
Severity Details Docs
Medium Title: Secret Keyword
config["snipe-it"]["apikey"] == "snipe-api-key-here"
📚

More info on how to fix Hard-Coded Secrets in General.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@m4us1ne
Copy link
Author

m4us1ne commented May 6, 2023

if you dont like the formatting and fstring stuff i am happy to open another mr with just that change

@jerm
Copy link
Member

jerm commented May 10, 2023

I don't dislike the formatting and fstring stuff, but yeah, I'd rather keep the changes separate, just for readability/evaluation sake.

Would really appreciate the separate PR for those bits

@m4us1ne m4us1ne closed this May 11, 2023
@m4us1ne m4us1ne mentioned this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants