Fixed Layer component animation bug when at mobile width #5274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com>
g4rry420
changed the title
jcfilben
approved these changes
May 25, 2021
ericsoderberghp
approved these changes
May 25, 2021
ShimiSun
approved these changes
May 25, 2021
halocline
changed the title
amitmishrg
added a commit
to mnet-ui/mnet-ui-base
that referenced
this pull request
Sep 14, 2021
* Testing upgrade (grommet#4999) * React 17 upgrade * removed extra code * Testing Library Upgrade * fix spacing and package.json Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Select Stories Improvements (grommet#4949) * Select stories improvements * removed comment from ChildrenRender * changes from review Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Drop should always scroll with target (grommet#4994) * Drop should scroll when doc scrolls * Add document as scrollParent Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Only toggle aria-hidden for DOM nodes coming from grommet (grommet#4979) * Only toggle aria-hidden for DOM nodes coming from grommet * Adjust comment placement * Dont support case w/o <Grommet> * Rename context, separate effects * Call roots, add comment, useEffect cleanup Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * [TS] Fix Heading, Text, Paragraph and Markdown Props declarations (grommet#4995) * Add TextExtendedProps interface * Add ParagraphExtendedProps interface * Add MarkdownExtendedProps interface * Fix statement ordering * Add HeadingExtendedProps interface * Use React.FC over React.ClassComponent Although the Markdown component imported from markdown-to-jsx is a class component, the exported GrommetMarkdown and GrommetMarkdownDoc components are functional components. Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Adding a new prop to validate form (grommet#4996) * Adding a new prop to verify form's validity * Addressing review comments * Adding unit tests * Adding new suite for onChange validation * Update valid story for a better end-end workflow picture * Update onChange validate test case Co-authored-by: Yashwanth Pinneka <ypinneka@nimblestorage.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Fix focusIndicator on inputStyle and update docs (grommet#4753) * Handle DataTable data reset with InfiniteScroll (grommet#4936) * Handle DataTable data reset with InfiniteScroll * Code refactor * Reuse similar code Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Changed Box hoverIndicator to accept elevation (grommet#5017) * Changed Box hoverIndicator to accept elevation * Added Box hoverIndicator test * Update src/js/components/Box/index.d.ts Co-authored-by: Shimi <shimrit.yacobi@gmail.com> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Change pendingValidation to create array (grommet#5026) * removed all material files * Allow Menu drop to be themed, any Drop props accepted (grommet#5005) * Allow menu drop alignment to be themed * Don't touch story * Add object to docs * Allow all drop props to be passed along to menu * Update base.js and base.d.ts * call const themeDropAlign Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Update button docs to clarify what relies on button.default (grommet#5025) Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Added 'rowDetails' to enable expansion of DataTable Rows (grommet#4975) * childComponent support for Datatable * Storybook changes and header fix * review comment fix * Changing the prop name from childComponent to rowDetails * Review comment changes * Readme changes * Update of test cases * addressing review comments Co-authored-by: Anoop Chandra B N <achandra@hpe.com> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * React 17 Upgrade (grommet#4991) * React 17 upgrade * removed extra code * allow v16 or v17 * switched dev dependencies to only support react 17 * included v17 in peerDependencies * removed support for v16 except in peer dependency Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Valid prop inside onValidate callback of Form was not considering the required case of Checkbox. (grommet#5014) * Checkbox to be considered for form's validity * Do not check validity for fields which are unmounted * Updating snaps * Addressing review comments * Addressing review comments and adding the filter back in useEffect * Addressing review comments * Adrdessing review comments Co-authored-by: Yashwanth Pinneka <ypinneka@nimblestorage.com> * Prevent app from crashing when Distribution value in values is not defined (grommet#5022) * throw error on Distribution when value in values is not defined * change from throwing error to handling no value * when value is not defined, don't display Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * fix Diagram, Distribution, DropButon, FileInput types (grommet#5021) Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * [TS] Fix TableRow and TableCell Prop Types (grommet#5009) * Add TableRowExtendedProps interface * Add TableCellExtendedProps interface Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * [TS] Fix Table, TableHeader, TableFooter and TableBody Prop Types (grommet#5008) * Add TableExtendedProps interface * Add TableBodyExtendedProps interface * Add TableHeaderExtendedProps interface * Add TableFooterExtendedProps interface Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Changed react-dom and elliptic deps to fix security issue (grommet#5042) * Added Drop props and theme support for 'margin', 'round' & 'background' (grommet#5046) * Added round, margin & background props to Drop * added theme support for props * Added tests to drop props * Updated types * Order alphabetically * Deprecated shadowSize to use elevation instead * Refined test names * Changed 'round' to be used as a util * Updated Chromatic on stories and refine theme elevation * Upgrade react-desc dependency (grommet#5048) * Form field error size theme doc (grommet#4985) * ADDED - docs for the table cell align prop is added Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * Test suites are runned using yarn test-update command to update the snpashots. Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * After running the git commit command, strangely test suites automatically removes and again add the same line in TableCell doc.js Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * ADDED the docs for the FormField.error.size theme property are added Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * MODIFIED-- All the values for the formField.error.size are added. Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * Update src/js/components/FormField/doc.js Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * fixed a small typo * UPDATED - docs are updated. Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * Update src/js/components/FormField/doc.js Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * UPDATED - docs are updated according to shimisun suggestion Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * [TS] Fix Sidebar, Stack, Tab and Tabs extended types (grommet#5016) * Add Tab extended type Signed-off-by: Miguel Marcondes <miguelmarcondesfilho@gmail.com> * Add Tabs extended type Signed-off-by: Miguel Marcondes <miguelmarcondesfilho@gmail.com> * Add Sidebar extended type Signed-off-by: Miguel Marcondes <miguelmarcondesfilho@gmail.com> * Add Stack extended type Signed-off-by: Miguel Marcondes <miguelmarcondesfilho@gmail.com> * Omitting children from divProps in Tabs Signed-off-by: Miguel Marcondes <miguelmarcondesfilho@gmail.com> * Omitting onClick from divProps in Sidebar Signed-off-by: Miguel Marcondes <miguelmarcondesfilho@gmail.com> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Fix warning on accordion custom story (grommet#5053) * Added tests for themed Tip (grommet#5055) * Added tests for themed Tip * Update src/js/components/Tip/__tests__/Tip-test.js * Changed Tip to use explicit props setting of Drop instead of using plain (grommet#5047) * Changed Tip to use explicit props setting of drop instead of using plain * Updated docs, tests and examples while extrating props to the theme * Update calendar bounds (grommet#5056) * Update bounds in CustomHeader.js story in Calendar * Update bounds in CustomHeadingSize.js story * Update bounds in Multiple.js story * Update bounds in Simple.js story Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Before the state gets updated validation is being run (grommet#5035) Co-authored-by: Yashwanth Pinneka <ypinneka@nimblestorage.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * [TS] Fix Accordion, AccordionPanel, Carousel and CheckBox extended types definition (grommet#5010) * Add AccordionExtendedProps type * Add AccordionPannelExtendedProps type * Add CarouselExtendedProps type * Add CheckBoxExtendedProps type * Export CheckBoxExtended interface * Export AccordionExtendedProps interface * Export AccordionPanelExtendedProps interface * Export CarouselExtendedProps interface * Fix AccordionProps interface Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * [TS] Fix Anchor, FormField, Image and TextArea extended types definition (grommet#5040) * Add AnchorExtendedProps type * Add FormFieldExtendedProps type * Add ImageExtendedProps type * Add TextAreaExtendedProps type * Change from type to interface in AnchorExtendedProps * Change from type to interface in FormFieldExtendedProps * Change from type to interface in ImageExtendedProps * Change from type to interface in TextAreaExtendedProps Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * [TS] Fix RadioButton, RadioButtonGroup, RangeInput and RangeSelector type interfaces (grommet#5018) * Add RadioButton extended props * Add RadioButtonGroupExtendedProps interface * Add RangeInputExtendedProps interface * Add RangeSelectorExtendedProps interface * Use React.FC instead of React.ComponentClass generic type Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * [TS] Fix Collapsible, List, Video and World Map extended type definitions (grommet#5058) * Fix collapsible extended props * Fix list extended props * Fix video extended props * Fix worldMap extended props * Allow DataTable to overflow but leave pagination controls in place (grommet#5065) * Update DataTable groupBy/select/onSelect docs (grommet#5066) Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Extended Avatar sizes (grommet#5071) * Shrink calendar days down to fit available space (grommet#5068) Co-authored-by: Tobias Lengsholz <tobias.lengsholz@invision.de> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Updated Spinner message docs (grommet#5075) * Disabled the header checkbox in the table if the table data is not (grommet#5073) present. Signed-off-by: AkshayChoulwar <achoulwar901@gmail.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Fix double focus on Select (grommet#5080) * [TS] Add Avatar, CheckBoxGroup, Chart and Clock extended props interfaces (grommet#5081) * Add AvatarExtendedProps interface * Add CheckBoxGroupExtendedProps interface * Add ClockExtendedProps type * Use React.FC over React.ComponentClass for Chart * [TS] Add Layer and Menu extended props interfaces, use React.FC for Chart and Select types (grommet#5083) * Use React.FC over React.ComponentClass for Chart * Add LayerExtendedProps interface * Add MenuExtendedProps interface * Use React.FC over React.ComponentClass for Select Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Only set focus on FormField if it containsFocus in the DOM (grommet#5089) * add focus to set on formfield * update yarn * revert yarn.lock back * make imports explicit * fix yarn lock * fix import Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> * Performance improvement (grommet#5078) Signed-off-by: Bojan Durdevic <bojan88@gmail.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Adjust rightOffset when caller applies pad on FileInput (grommet#5094) * Adjust rightOffset when caller applies pad * Add comment * Updated v2.17.0 * Fix layer animation on exit (grommet#5097) Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Updating List docs to fix html entities conversion. (grommet#5091) Signed-off-by: Zack Urben <zackurben@gmail.com> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * [TS] Add Box, Button, Calendar and Drop extended props interfaces (grommet#5085) * Add BoxExtendedProps interface * Add ButtonExtendedProps interface * Add CalendarExtendedProps interface * Add DropExtendedProps interface * Use React.FC instead of React.ComponentClass for Drop Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * [TS] Add Spinner and MaskedInput extended props interfaces (grommet#5084) * Add SpinnerExtendedProps interface * Add MaskedInputExtendedProps interface Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * [Notification] autoClose config support * Type render functions of calendar component (grommet#5074) Co-authored-by: Tobias Lengsholz <tobias.lengsholz@invision.de> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * [TS] Add DataTable, Grid and Grommet extended props interfaces, use React.FC for InfiniteScroll type (grommet#5082) * Add DataTableExtendedProps interface * Add GridExtendedProps interface * Add GrommetExtendedProps interface * Use React.FC over React.ComponentClass for Infinitescroll Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Notification close icon styling * Fix InfiniteScroll loop when Data length changes (grommet#5100) Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * fix(StyledAnchor): prevent custom props from bleeding into DOM (grommet#5061) * fix(styledanchor): prevent custom props from bleeding into DOM and throwing warnings in console * fix(anchor props): add focus and reverse to array of not-allowed-to-reach-DOM props Co-authored-by: Mihai Ro <mihairo@192-168-0-102.rdsnet.ro> Co-authored-by: Mihai Ro <mihairo@192-168-0-106.rdsnet.ro> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Updated v2.17.1 * Updated icon in multiselect * Fix Pagination TS definition and make .tsx story (grommet#5121) * Fix Ts definition and make tsx story * Remove commented out code * Signed-off-by: andrewthamcc <andrew.tham.cc@gmail.com> (grommet#5109) fix prop typings for CalendarHeader and MaskedInput Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * update docs for color prop in button (grommet#5120) * update docs for color prop in button * Update src/js/components/Button/doc.js Co-authored-by: taysea <taylor.seamans@yahoo.com> * update docs * update docs to include which buttons backgrounds change Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: taysea <taylor.seamans@yahoo.com> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Make ListProps and ListExtendedProps generic (grommet#5110) Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Enhance DataTable to support groupBy and onSelect together (grommet#5101) * Enhance DataTable to support groupBy and onSelect atogether * Update docs * Simplify story * Check onSelect values Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Don't let Layer elevation leak to DOM, don't apply elevation when plain (grommet#5131) * Dont let elevation leak to DOM, dont apply when plain * Update doc for plain and test * Pass aria-label prop through as button attribute. (grommet#5119) Previously we only used the a11yTitle prop for button aria labels. This is a little unintuitive to someone who is already familiar with a11y. Rather than deprecate that prop we allow for it in addition to the a11yTitle prop. Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Fix formfield ts (grommet#5126) * update docs for color prop in button * Update src/js/components/Button/doc.js Co-authored-by: taysea <taylor.seamans@yahoo.com> * update theme for formfield ts * . * just adding & error color Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: taysea <taylor.seamans@yahoo.com> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Add ref to Select props type (grommet#5136) * Pagination utility to return empty array of current items if data is passed in as array (grommet#5135) * Return empty array if no currentItems * useMemo to avoid infinite loop * Use null instead of undefined * Pagination func cleanup * Only show pagination controls when data.length > step, write tests * Update DataTable Checkbox styling, allow plain column render (grommet#5077) * Update DataTable Checkbox styling, allow plain column * Merge master * Fix height and master changes * Update docs * Fix height calc * Pad default to undefined * Dont include border in cell height * Merge master * Prop value noPad * Update docs * Dont adjust default pad value * Update docs and prop passing * Incorporate review feedback Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * DateInput leading zeros and 2 digit year format option (grommet#5150) * Added leading zero functionality to DateInput * updated docs Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Enhance Drop to account for align when assigning margin (grommet#5029) * enhance drop to position margin correctly when provided * Update src/js/components/Drop/StyledDrop.js Co-authored-by: taysea <taylor.seamans@yahoo.com> * Update src/js/components/Drop/StyledDrop.js Co-authored-by: taysea <taylor.seamans@yahoo.com> * Update src/js/components/Drop/__tests__/Drop-test.js Co-authored-by: taysea <taylor.seamans@yahoo.com> * Update src/js/components/Drop/doc.js Co-authored-by: taysea <taylor.seamans@yahoo.com> * Update src/js/components/Drop/doc.js Co-authored-by: taysea <taylor.seamans@yahoo.com> * Update src/js/components/Drop/doc.js Co-authored-by: taysea <taylor.seamans@yahoo.com> * fix layer in base js and update docs * update docs * update to accept edge size * make changes to drop to align with new PR * merge with master * clean up unnessary code * clean up changes * take out console.logs * add export round storybook * add check for customcss * better naming convention * add tests for all align positions * Move test and add else * Alphabetize base.d.ts * Update src/js/components/Drop/doc.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * address feedback * add comment * clean up if statements * add better description Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: taysea <taylor.seamans@yahoo.com> Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Adtag feedback changes * MultiSelct selected chip style change * scroller style changes * Fixed Box to always render ThemeContext.Provider (grommet#5158) * AdUnit feedback changes * change image in story (grommet#5169) Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> * add new fill prop to checkbox (grommet#5153) * add new fill prop to checkbox * Update src/js/components/CheckBox/CheckBox.js Co-authored-by: taysea <taylor.seamans@yahoo.com> * Update src/js/components/CheckBox/doc.js Co-authored-by: taysea <taylor.seamans@yahoo.com> * clean up prop and story * clean up fun and desc * fix return * add prop to typescript * update docs Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: taysea <taylor.seamans@yahoo.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Trigger `change` event when Select value changes (grommet#5155) * Trigger change event when select changes and is in form * Update story * Alphabetize * Update src/js/components/Select/Select.js * Only trigger change event if correct nextValue type * Remove unnecessary dependency * Update comment * Remove __input from story * Update test Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * safe array check added * Button tip text default for a11y (grommet#5156) * Button tip string should be used for a11yTitle default value if none provided grommet#5152 Signed-off-by: Samuel Goff <samuel@defpix.com> * grommet#5152 feedback from @ShimiSun: return undefined instead of empty string & add support for StyledButtonKind Signed-off-by: Samuel Goff <samuel@defpix.com> * grommet#5152 feedback from @ShimiSun: eliminate unnecessary white space changes Signed-off-by: Samuel Goff <samuel@defpix.com> * grommet#5152 feedback from @ShimiSun: eliminate unnecessary white space changes Signed-off-by: Samuel Goff <samuel@defpix.com> * grommet#5152 feedback from @ShimiSun: eliminate unnecessary white space changes Signed-off-by: Samuel Goff <samuel@defpix.com> * grommet#5152 feedback from @ShimiSun: eliminate unnecessary white space changes Signed-off-by: Samuel Goff <samuel@defpix.com> * Update src/js/components/Button/Button.js Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * replace function with inline default assignment Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Changed React events to apply on Checkbox container level (grommet#5171) * Changed React events to apply on checkBox container level * Updated optional chaining * Fix CheckBox fill prop behavior and type warnings (grommet#5173) * Fix CheckBox fill prop behavior and type warnings * Fix CheckBox props DOM leak Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * master merge * removed dist folder * reverted gitignore file * updated package.json & multiSelect stories * Collapse btn in searchBox * CheckBox review changes * Reverting not needed files * reverting files * Added snapshot test for ResponsiveContext. Related to issue grommet#5103 (grommet#5176) * formfield as generic (grommet#5088) Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Changed Select to fix an issue with onChange + valueLabel (grommet#5181) * Tooltip file changes * StyledTextInput file changes * Minimizing required changes in mnet-ui-base * Minimizing required changes in mnet-ui-base * Minimizing required changes in mnet-ui-base * Minimizing required changes in mnet-ui-base * Fix CheckBoxGroup types (grommet#5180) Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * made select column pay attention to table pin property (grommet#5177) * made select column pay attention to table pin property * pulled calcBackground into buildState * apply theme extensions to select header/footer Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Minimizing required changes in mnet-ui-base * Minimizing required changes in mnet-ui-base * Allow DateInput value to initialize as [] (grommet#5179) * Allow DateInput dates to initialize as [] * Fix jest test * Make test logic more clear * Ensure test will pass with 2 digit months * Ensure test will pass with 2 digit timezone offset * Update src/js/components/DateInput/DateInput.js Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> * Lint Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * adunit rewamp refactor changes * Select cmp refctor changes * Fix SSR warnings with an isomorphic useLayoutEffect (grommet#5157) * Introducing an alternative useLayoutEffect hook, which does not yield warnings in SSR. Added eslint rules to enforce its usage instead of React's vanilla useLayoutEffect. Fixed the entire codebase accordingly. This fixes grommet#4765. The fix is based on Alex Reardon's blog at https://medium.com/@alexandereardon/uselayouteffect-and-ssr-192986cdcf7a Signed-off-by: Oran Epelbaum <oran.nospam@avian.aero> * Removed redundant eslint rule. It is not really needed because the export from use-isomorphic-layout-effect is already named useLayoutEffect. Also made the error message for the other eslint rule clearer. Signed-off-by: Oran Epelbaum <oran.nospam@avian.aero> * reduced import surface, and added a default export. Co-authored-by: MikeKingdom <michael.kingdom@hpe.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * [TS] DateInput type definition is missing disabled prop (grommet#5165) * Add disabled prop type to DateInputProps * Add disabled description in doc.js * Update readme * Add test to check disabled * Add input IntrinsicElement * update snapshots * Remove disabled prop from DateInputProps * add snapshot for dateinput test * Remove disabled from docs * update snapshoots Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Changed RadioButtonGroup to add defaultValue (grommet#5184) Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Run validations on form when component (Formfield) mounts grommet#5049 (grommet#5187) * Validate fields on mount * Added comment at the appropriate place Co-authored-by: Yashwanth Pinneka <ypinneka@nimblestorage.com> * Fix Select type to select functionality (grommet#5186) Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Fix for missing code in Grid Pagination storybook (grommet#5188) * Fix for missing code in Grid Pagination storybook Signed-off-by: Bojan Durdevic <bojan88@gmail.com> * Reverted changes, and fixed missing storybook code differently Signed-off-by: Bojan Durdevic <bojan88@gmail.com> * Keep the errors/infos format consistent (grommet#5190) * Remove errors or infos that dont have any validations * Addressing review comments * Add test case for valid flag Co-authored-by: Yashwanth Pinneka <ypinneka@nimblestorage.com> * VALID flag of Form's validation results callback is not accurate on initial mount (grommet#5195) * Validation to be run after required fields are set * Addressing review comments & using required fields via useRef * Update story accordingly to show validation errors on mount Co-authored-by: Yashwanth Pinneka <ypinneka@nimblestorage.com> * refactor changes * refactor changes * refactor changes * refactor changes * Updated v2.17.2 * Make DataTable's groupBy togglable (grommet#5140) * fix(DataTable): key should be unique * test(DataTable): toggle groupBy * fix(DataTable): update groupState when groupBy prop is changed * feat(DataTable): make euqality check more robust * fix(DataTable): lint * refactor(DataTable): introduce useGroupState Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * fix: only show focus on keyboard use (grommet#5148) Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com> * Pagination update on page prop change (grommet#5191) * Removed trailing whitespaces, and snaps update Signed-off-by: Bojan Durdevic <bojan88@gmail.com> * Update page on prop change Signed-off-by: Bojan Durdevic <bojan88@gmail.com> * Added snap for pagination prop update test Signed-off-by: Bojan Durdevic <bojan88@gmail.com> * Better test assertion, and snapshot update Signed-off-by: Bojan Durdevic <bojan88@gmail.com> * Moved hook closer to active page Signed-off-by: Bojan Durdevic <bojan88@gmail.com> * Collapsibe render issue fix (grommet#4984) * Collapsible refactored Signed-off-by: Bojan Durdevic <bojan88@gmail.com> * Fix for horizontal Signed-off-by: Bojan Durdevic <bojan88@gmail.com> * More improvements Signed-off-by: Bojan Durdevic <bojan88@gmail.com> * Formatting change Signed-off-by: Bojan Durdevic <bojan88@gmail.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Fix for native event in Select component (Preact support) (grommet#5098) * Fix for native event in Select component Signed-off-by: Bojan Durdevic <bojan88@gmail.com> * PR comment addressed - using event.constructor for both event types Signed-off-by: Bojan Durdevic <bojan88@gmail.com> * Revert "PR comment addressed - using event.constructor for both event types" This reverts commit f6dc658. Signed-off-by: Bojan Durdevic <bojan88@gmail.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * refactor changes * Select cmp changes * File not needed * BoxSnowpack test component -- Revert before next release (grommet#5202) * BoxSnowpack test example * DateInput snapshots for May 2021 Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Add role to CheckBoxGroup and RadioButtonGroup (grommet#5209) * Allow SkipLinks to have single child (grommet#5211) Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Changed Meter to add type='pie' (grommet#5219) * Changed Meter to add type='pie' * Cleaned up incorrect documentation * adds missing import for defaultProps (grommet#5229) Signed-off-by: Daniel Baird <daniel.baird@jcu.edu.au> * review changes * Vertical meter (grommet#5052) * ADDED - docs for the table cell align prop is added Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * Test suites are runned using yarn test-update command to update the snpashots. Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * After running the git commit command, strangely test suites automatically removes and again add the same line in TableCell doc.js Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * ADDED the docs for the FormField.error.size theme property are added Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * MODIFIED-- All the values for the formField.error.size are added. Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * Update src/js/components/FormField/doc.js Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * fixed a small typo * UPDATED - docs are updated. Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * Update src/js/components/FormField/doc.js Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * UPDATED - docs are updated according to shimisun suggestion Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * MODIFIED: vertical direction for meter is added Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * Refactored the codebase Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * refactored the codebase as eric suggested Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * Update src/js/components/Meter/index.d.ts Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Added the reverse() to keep the caps looks right Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Added Meter vertical test and fixed a story (grommet#5242) * Fix RangeSelector to respond to touch gestures (grommet#5139) * Fix RangeSelector to respond to touch gestures * chore: update toMatchSnapshot call to after events * Fix onTouchMove handler Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Update snapshot Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Updated postcss package to clear security vulnerability (grommet#5244) * Updated dependencies (grommet#5245) * Updated dependencies (grommet#5246) * Updated dependencies * Updated dependencies * Updated dependencies * Updated dependencies * Updated dependencies * Missing target fix when valueLabel prop used in Select component (grommet#5235) * Select with value label fix for event.target.value * Snaps for select valueLabel fix * Test update to check for event.target.value when Select has valueLabel * Using styled component for hidden input for Select component Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * fix aria-label in drop button (grommet#5234) * fix aria-label in drop button * clean up code feedback Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Fix Chart `opacity` prop to allow boolean value (grommet#5227) * update Chart opacity prop to align with docs * created getOpacity function Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * move down prevent default (grommet#5222) Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: taysea <taylor.seamans@yahoo.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Improved TextInput custom suggestions example (grommet#5216) Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * removed BoxSnowpack (grommet#5251) * Enhance date and dates (grommet#5030) * ADDED - docs for the table cell align prop is added Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * Test suites are runned using yarn test-update command to update the snpashots. Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * After running the git commit command, strangely test suites automatically removes and again add the same line in TableCell doc.js Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * ADDED the docs for the FormField.error.size theme property are added Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * MODIFIED-- All the values for the formField.error.size are added. Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * ADDED AND MODIFIED - modfied date prop to accept array also and added some stories test related to it. * ADDED - added more stories for the test date prop to accept array datatype also Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * Added the reusable function in Calendar.js for date and dates state Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * resolved conflicts Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * Update src/js/components/Calendar/Calendar.js Co-authored-by: taysea <taylor.seamans@yahoo.com> * Added docs and changed props in index.d.ts in Calendar component Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * some console logs to test * some console logs to test * console.log tests Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * Fixed the bug for selecting date in Calendar Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * Simplify duplication of code * Update src/js/components/Calendar/index.d.ts Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Refactored the dateCaller function to as normalizeDate Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> Co-authored-by: taysea <taylor.seamans@yahoo.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * fix anchor so if size is passed in prop (grommet#5210) * fix anchor so if size is passed in prop * move test below orginal * fix logic so it stays backward compatible * clean up story Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Add `badge` prop to Button (grommet#5213) * Add badge to Button * Add storybook * Incorporate feedback, refine badge placement, update docs * Improve docs wording * Adjust comment * Add test for target * Incorporate feedback, make Button/Badge.js * Fix logic * Fix docs * Update theme structure * Incorporate theme/pad feedback * Remove unneccessary type * Adjust when styling is applied, other feedback * Remove border, handle offset/width calculations * Cleanups * Add comment about resize Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Update Select docs to clarify value, labelKey (grommet#5217) * Update Select docs to clarify value, labelKey * Update src/js/components/Select/doc.js Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * update docs Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> * Enhance DataTable multiple pinning (grommet#5161) * Enhance DataTable multiple pinning * Multiple Pinning logic rework * Rework logic to avoid max update depth * separate responsibilities on DataTable multi pin * improve variables naming Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * refactor changes * refactor changes * revert: not req changes * Remove polished package (grommet#5255) * Removed polished package and used getRGBA function available in utils Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * Removed polished package and used getRGBA function available in utils Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * spacing issue in rgba from StyledRangeInput Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Enhance Button badge docs (grommet#5263) * Enhance badge docs * Clarify wording * tolltip right align changes * revert: tolltip right align changes * Changed Grid to add width and height (grommet#5265) * Changed Grid to add width and height * Use @testing-library for new tests * add an option to align the label and text in checkbox (grommet#5203) * add an option to align the label and text in checkbox * Update src/js/themes/base.d.ts Co-authored-by: taysea <taylor.seamans@yahoo.com> * Update src/js/components/CheckBox/README.md Co-authored-by: taysea <taylor.seamans@yahoo.com> * update docs * add align type * Update src/js/components/CheckBox/README.md Co-authored-by: taysea <taylor.seamans@yahoo.com> * update align and address feedback * fix typescript * remove import Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: taysea <taylor.seamans@yahoo.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * add back in scroll for select (grommet#5230) * add back in scroll for select * take out console * clean up some code * take scroll to be handeled in iinfiniteScroll Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Controlled Carousel use case (grommet#5116) * Controlled Carousel use case * Properties consistently naming * fix carousel index fallback Co-authored-by: Taylor Seamans <taylor.seamans@yahoo.com> * add theme button as option for fileinput (grommet#5183) * add theme button as option for fileinput * add changes to fileinput * fix margin * fix typo for css removing outline of focus * Update src/js/components/FileInput/FileInput.js Co-authored-by: taysea <taylor.seamans@yahoo.com> * add border behavior to be in formfield when wrapping fileinput * fix spacing between remove and browse * fix calculation of right pad * fix overflow of remove and browse box * remove const of fileinput put inline * clean up map * put back inner props to empty object to be backward compatable * take out focus if fileinput * fix a invalid prop warning * add border to custom story for visual * add fileinput as an example to form for visual on how it looks when validation * change when button or anchor appears * take out outline this is not needed * fix unused function * refoormat fileinput * add comments to formfield to explain border * take out un needed code * use parseMetric * add color border when hover * changes per feedback * update tests * clean up feedback * change logic for right pad * take in account aggregateThreshold * change style for aggregatethreshold * fix box from shrinking * fix flex so box does not shrink * Update src/js/components/FileInput/FileInput.js Co-authored-by: taysea <taylor.seamans@yahoo.com> * change state to object * fix stories with fileinput * fix cursior behavior * Update src/js/components/FileInput/stories/Custom.js Co-authored-by: Shimi <shimrit.yacobi@gmail.com> Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: taysea <taylor.seamans@yahoo.com> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Fix: Peer review changes * Fix: Peer review changes * Changed Grid to enhance columns capabilities (grommet#5276) * Changed Grid to enhance columns capabilities * Fixed an issue with constraining to 100% width * Add align center to fileinput (grommet#5279) * Changed Grommet to add full='min' (grommet#5278) Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Changed DateInput to create smarter masks for MaskedInput. (grommet#5277) * Changed DateInput to create smarter masks for MaskedInoput. Fixes issue grommet#5273 * Fixed an issue with short format * Fixed time and zone alignment Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Fixed an issue with Grid columns when building minmax (grommet#5280) Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Peer review Changes * Upgrade major/minor/patch versions of packages (grommet#5282) * Upgrade major/minor/patch versions of packages * Resolved conflicts * fixed the bug for animation mobile for layer component (grommet#5274) Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Multiselect story changes * Fix: collapsible btn css issue * Show display value optimization * refactor changed req for MP * removed console log * Changed List to add onOrder (grommet#5212) * Changed List to add onOrder * keyboard tweaks and accessibility * Address feedback. Add role=option for accessibility * Update List test * Added onOrder tests Co-authored-by: Mike Kingdom <michael.kingdom@hpe.com> * MultiSelct position change * Fix keyboard behavior of RadioButtonGroup (grommet#5284) * Fix keyboard behavior of radiobuttongroup * Fix keyboard for Firefox when no selection * Add clarifying comments * Changed MaskedInput to add textAlign (grommet#5285) Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Remove duplicate focus styling on CheckBox/CheckBoxGroup inside FormField (grommet#5288) * Enhance CheckBox focus styling * Fix theme object * Use optional chaining Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Normalize theme.checkBox.toggle.color directly rather than switching on light/dark (grommet#5272) Co-authored-by: Matt Glissmann <mdglissmann@gmail.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Refactor Accordion, Anchor tests to use `render` @testing-library function (grommet#5238) * refactor Accordion render component * refactor Anchor render component Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> * Dev QA changes * update dateinput snapshots for June (grommet#5294) * Small fixes in storybook stories (grommet#5295) * Add options prop to Grommet to support configurations (grommet#5270) * add option in theme for id on layer * add an option in grommet for single id * delete unneeded code * update docs on grommet * Update src/js/components/Layer/stories/Round.js Co-authored-by: taysea <taylor.seamans@yahoo.com> * Update src/js/components/Layer/stories/Round.js Co-authored-by: taysea <taylor.seamans@yahoo.com> * Update context and docs * Update src/js/components/Grommet/index.d.ts * Create defaultOptions * Clarify docs * Update docs Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: taysea <taylor.seamans@yahoo.com> * bump node version, upgrade and remove some packages (grommet#5297) Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Fixed accordionpanel icon position issue with truncated text (grommet#5259) * fixed accordionpanel icon position issue with truncated text Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> * resolved conflicts Signed-off-by: gurkiran_singh <gurkiransinghk@gmail.com> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> * Updated v2.17.3 * Fix: issue in CDP - Configuring functionalities * fix: tooltip border issue * fix: tooltip border issue * tooltip changes * Added workflow * Workflow: Modified workflow * Fix: MultiSelect size cmp bug * workflow change * empty commit * empty commit * temp: workflow change * temp * revert 6c8e412 * Fix: Multiselect size cmp * Updated mnet-ui-bse package * minor change * storybook fixes * configuring workflow * downgrade node version * unused config * temp * reverted last commit * GrommetCompare: removed code from SelectContainer * workflow update * revert workflow * temp * temp * Workflow change * Select cmp fixes * Eslist changes * Confirm Pop up button changes * FormField Added Own changes * Form field changes * temp * temp * tertiary support for button * Fix: Checkbox undefined import & Select infinite loop * Switch theme change * multiselect options blank issue resolved * multiselect options blank issue resolved * Fix-multiselect-btn-color-issue * multiselect button changes * Fix eslint issue * Select cmp changes revert * test snapshots update * Not required stories * tooltip changes * tooltip changes * icon color change * icon color change * Select cmp isse resolved * support for isOpenState config update in MultiSelect Co-authored-by: Jessica Filben <54560994+jcfilben@users.noreply.github.com> Co-authored-by: Eric Soderberg <eric.soderberg@hpe.com> Co-authored-by: Shimi <shimrit.yacobi@gmail.com> Co-authored-by: taysea <taylor.seamans@yahoo.com> Co-authored-by: Matthew Glissmann <mdglissmann@gmail.com> Co-authored-by: Alex Mirrington <34053287+alexmirrington@users.noreply.github.com> Co-authored-by: ypinneka <60210530+ypinneka@users.noreply.github.com> Co-authored-by: Yashwanth Pinneka <ypinneka@nimblestorage.com> Co-authored-by: Leonardo Santiago <47114840+leossantiago@users.noreply.github.com> Co-authored-by: prashant.gur <prashant.gur@media.net> Co-authored-by: Anoop Chandra <anoop.advaitha@gmail.com> Co-authored-by: Anoop Chandra B N <achandra@hpe.com> Co-authored-by: Abner Soares Alves Junior <abnersajr@gmail.com> Co-authored-by: g4rry420 <61521805+g4rry420@users.noreply.github.com> Co-authored-by: Miguel Marcondes Filho <47646621+miguelmarcondesf@users.noreply.github.com> Co-authored-by: Isaias Carvalho <isaigrec@gmail.com> Co-authored-by: Lucas Rodrigues <lucasrodrigues123@hotmail.com.br> Co-authored-by: Jeferson S. Brito <30840709+jeferson-sb@users.noreply.github.com> Co-authored-by: Tobias Lengsholz <tobias@lengsholz.de> Co-authored-by: Tobias Lengsholz <tobias.lengsholz@invision.de> Co-authored-by: Akshay Choulwar <achoulwar901@gmail.com> Co-authored-by: britt6612 <42451602+britt6612@users.noreply.github.com> Co-authored-by: Brittany Archibeque <brittanyarchibeque@Brittanys-MacBook-Pro-2.local> Co-authored-by: Bojan Đurđević <bojan88@gmail.com> Co-authored-by: Zack Urben <zackurben@gmail.com> Co-authored-by: prashant.gur@gmail.com <prashant.gur@gmail.com> Co-authored-by: amit.mish <amitmishra009v@gmail.com> Co-authored-by: Mihai Ro <15910058+mihai-ro@users.noreply.github.com> Co-authored-by: Mihai Ro <mihairo@192-168-0-102.rdsnet.ro> Co-authored-by: Mihai Ro <mihairo@192-168-0-106.rdsnet.ro> Co-authored-by: Andrew Tham <45271739+andrewthamcc@users.noreply.github.com> Co-authored-by: kid-icarus <ryan.kois@gmail.com> Co-authored-by: Jason Ross <jasnross@gmail.com> Co-authored-by: MikeKingdom <michael.kingdom@hpe.com> Co-authored-by: samuelgoff <samuel@defpix.com> Co-authored-by: exromany <exromany@gmail.com> Co-authored-by: Oran Epelbaum <oran@epelbaum.me> Co-authored-by: Johnathan Giang <jayhgiang@gmail.com> Co-authored-by: watiko <watiko@users.noreply.github.com> Co-authored-by: Alan Souza <alansouzati@gmail.com> Co-authored-by: Daniel Baird <daniel@danielbaird.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: gurkiran_singh gurkiransinghk@gmail.com
What does this PR do?
Fixed the animation bug in mobile resoltion for Layer Component
Where should the reviewer start?
components => Layer => StyledLayer.js
What testing has been done on this PR?
yarn test-update
How should this be manually tested?
Try to animate any story with Layer in mobile resolution
Any background context you want to provide?
No
What are the relevant issues?
#5236
Screenshots (if appropriate)
Do the grommet docs need to be updated?
No
Should this PR be mentioned in the release notes?
Is this change backwards compatible or is it a breaking change?
backwards compatible