-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme-defined backgrounds #6310
Theme-defined backgrounds #6310
Conversation
Fix coming for the Jest tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. It's a pretty cool feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! not sure if you wanted to make a separate issue for the opacity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this, good additions.
Just need to bump the bundle size: https://app.circleci.com/pipelines/github/grommet/grommet/12271/workflows/3aeb17bf-ef65-4658-b70e-03b3b3a54609/jobs/61755 |
Done. |
What does this PR do?
Closes #6291
<Box background="gradient-1" ... />
or<Box background="image-3" ... />
.background
prop object to support background-clip.background
prop object to support rotate, specified in degrees. Note: Implementation only supports rotation of linear-gradients at this time. Proper support for rotating images requires image resizing and repositioning and would need to be thought through from an API perspective.Backgrounds may be a string,
{dark, light}
object, orBackgroundTypeobject.Where should the reviewer start?
background.js
What testing has been done on this PR?
How should this be manually tested?
Storybook --> Use the Box/stories/TEMP.js story
Do Jest tests follow these best practices?
screen
is used for querying.userEvent
is used in place offireEvent
.asFragment()
is used for snapshot testing.Any background context you want to provide?
What are the relevant issues?
#6291
Screenshots (if appropriate)
Do the grommet docs need to be updated?
Yes.
Should this PR be mentioned in the release notes?
Yes.
Is this change backwards compatible or is it a breaking change?
Backwards compatible.