fix: dropProps should accept inline style #6431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsoderberghp
approved these changes
Oct 18, 2022
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows
dropPropsof Tip to accept inline style.Where should the reviewer start?
Tip types
What testing has been done on this PR?
local
How should this be manually tested?
Use
styleprop inline withdropPropsof TipDo Jest tests follow these best practices?
N/A
Any background context you want to provide?
What are the relevant issues?
#types
Screenshots (if appropriate)
Do the grommet docs need to be updated?
types
Should this PR be mentioned in the release notes?
As a TS issue
Is this change backward compatible or is it a breaking change?
backward compatible