logical_range_filter: Add support for immediate un-reference of shards #1330

HashidaTKS · 2022-03-03T03:32:55Z

Add support for immediate un-reference of shards.

Behavior before patched

All shards are un-referred at the end of the command.

Behavior after patched

Shards that are no longer referred are un-referred immediately.

plugins/sharding/logical_range_filter.rb

HashidaTKS · 2022-03-10T08:22:43Z

I am testing performance and will add results to this PR after I finish the test.
Although just waiting for finish, it will take time a little.

@kou , @komainu8
Would you please review this before I finish the performance test?

komainu8 · 2022-03-11T00:16:16Z

@HashidaTKS
This PR fails all tests on CI.
Are these failures due to your modifications?

HashidaTKS · 2022-03-11T01:03:37Z

Maybe they are due to my modification. I'll fix them.

HashidaTKS · 2022-03-11T04:50:28Z

They have been fixed by rebasing to groonga:master

kou · 2022-03-11T09:01:32Z

plugins/sharding/logical_enumerator.rb

+
+      def reverse_each_with_index(&block)
+        each_with_index_internal(:descending, &block)
+      end


You don't need them with the change:

diff --git a/plugins/sharding/logical_enumerator.rb b/plugins/sharding/logical_enumerator.rb index 79e5f7003..5dde0fb8f 100644 --- a/plugins/sharding/logical_enumerator.rb +++ b/plugins/sharding/logical_enumerator.rb @@ -28,6 +28,7 @@ module Groonga private def each_internal(order) + return enum_for(__method__, order) unless block_given? context = Context.instance each_shard_with_around(order) do |prev_shard, current_shard, next_shard| shard_range_data = current_shard.range_data

Then you can use like enumerator.each.with_index.

Great, I didn't know that!

kou · 2022-03-11T09:02:13Z

plugins/sharding/logical_enumerator.rb

@@ -63,9 +72,35 @@ def each_internal(order)
        end
      end

+      private


This is needless.

This method is removed.

kou · 2022-03-11T09:02:18Z

plugins/sharding/logical_enumerator.rb

+        end
+      end
+
+      private


This is needless.

This method is removed.

plugins/sharding/logical_enumerator.rb

kou · 2022-03-15T00:31:30Z

Can we test this change by adding #@add-important-log-levels or something to existing tests?

plugins/sharding/logical_enumerator.rb

kou

How about adding Shard#first? and Shard#last? instead of checking index?

diff --git a/plugins/sharding/logical_enumerator.rb b/plugins/sharding/logical_enumerator.rb
index 94e8c3437..0c2d334ee 100644
--- a/plugins/sharding/logical_enumerator.rb
+++ b/plugins/sharding/logical_enumerator.rb
@@ -6,7 +6,6 @@ module Groonga
       attr_reader :target_range
       attr_reader :logical_table
       attr_reader :shard_key_name
-      attr_reader :size
       def initialize(command_name, input, options={})
         @command_name = command_name
         @input = input
@@ -23,20 +22,13 @@ module Groonga
         each_internal(:descending, &block)
       end
 
-      def each_with_index(&block)
-        each_with_index_internal(:ascending, &block)
-      end
-
-      def reverse_each_with_index(&block)
-        each_with_index_internal(:descending, &block)
-      end
-
       def unref
         @shards.each(&:unref)
       end
 
       private
       def each_internal(order)
+        return enum_for(__method__, order) unless block_given?
         context = Context.instance
         each_shard_with_around(order) do |prev_shard, current_shard, next_shard|
           shard_range_data = current_shard.range_data
@@ -72,35 +64,10 @@ module Groonga
         end
       end
 
-      private
-      def each_with_index_internal(order)
-        index = 0
-        each_internal(order) do |shard, shard_range| 
-          yield(shard, shard_range, index)
-          index += 1
-        end
-      end
-
-      private
-      def compute_size
-        context = Context.instance
-        prefix = "#{@logical_table}_"
-        size = 0
-        context.database.each_name(:prefix => prefix) do |name|
-          shard_range_raw = name[prefix.size..-1]
-  
-          if shard_range_raw =~ /\A(\d{4})(\d{2})\z/ ||
-             shard_range_raw =~ /\A(\d{4})(\d{2})(\d{2})\z/
-            size += 1
-          end
-        end
-        size
-      end
-
       def each_shard_with_around(order)
         context = Context.instance
         prefix = "#{@logical_table}_"
-        unref_immediately = @options[:unref_immediately] || false
+        unref_immediately = @options.fetch(:unref_immediately, false)
 
         shards = [nil]
         context.database.each_name(:prefix => prefix,
@@ -118,6 +85,11 @@ module Groonga
           end
 
           shard = Shard.new(name, @shard_key_name, shard_range_data)
+          previous_shard = shards.last
+          if previous_shard
+            shard.previous_shard = previous_shard
+            previous_shard.next_shard = shard
+          end
           shards << shard
           @shards << shard
           next if shards.size < 3
@@ -154,7 +126,6 @@ module Groonga
         end
 
         @target_range = TargetRange.new(@command_name, @input)
-        @size = compute_size
       end
 
       def compute_month_shard_max_day(year, month, next_shard_range)
@@ -167,12 +138,16 @@ module Groonga
 
       class Shard
         attr_reader :table_name, :key_name, :range_data
+        attr_accessor :previous_shard
+        attr_accessor :next_shard
         def initialize(table_name, key_name, range_data)
           @table_name = table_name
           @key_name = key_name
           @range_data = range_data
           @table = nil
           @key = nil
+          @previous_shard = nil
+          @next_shard = nil
         end
 
         def table
@@ -187,8 +162,12 @@ module Groonga
           @key ||= Context.instance[full_key_name]
         end
 
-        def copy
-          Shard.new(@table_name, @key_name, @range_data)
+        def first?
+          @previous_shard.nil?
+        end
+
+        def last?
+          @next_shard.nil?
         end
 
         def unref
diff --git a/plugins/sharding/logical_range_filter.rb b/plugins/sharding/logical_range_filter.rb
index add7355fa..811000903 100644
--- a/plugins/sharding/logical_range_filter.rb
+++ b/plugins/sharding/logical_range_filter.rb
@@ -118,7 +118,7 @@ module Groonga
         def initialize(input)
           @input = input
           @use_range_index = parse_use_range_index(@input[:use_range_index])
-          @enumerator = LogicalEnumerator.new("logical_range_filter", 
+          @enumerator = LogicalEnumerator.new("logical_range_filter",
                                               @input,
                                               {:unref_immediately => true})
           @order = parse_order(@input, :order)
@@ -262,13 +262,10 @@ module Groonga
         end
 
         def execute
-          first_shard = nil
+          have_shard = false
           have_result_set = false
           each_shard_executor do |shard_executor|
-            if first_shard.nil?
-              first_shard = shard_executor.shard.copy
-              @context.referred_objects << first_shard
-            end
+            have_shard = true
             shard_executor.execute
             @context.consume_result_sets do |result_set|
               have_result_set = true
@@ -276,7 +273,7 @@ module Groonga
             end
             break if @context.current_limit.zero?
           end
-          if first_shard.nil?
+          unless have_shard
             enumerator = @context.enumerator
             message =
               "[logical_range_filter] no shard exists: " +
@@ -284,9 +281,12 @@ module Groonga
               "shard_key: <#{enumerator.shard_key_name}>"
             raise InvalidArgument, message
           end
-          unless have_result_set
+          return if have_result_set
+
+          each_shard_executor do |shard_executor|
+            shard = shard_executor.shard
             result_set = HashTable.create(:flags => ObjectFlags::WITH_SUBREC,
-                                          :key_type => first_shard.table)
+                                          :key_type => shard.table)
             @context.push
             @context.temporary_tables << result_set
             targets = [[result_set]]
@@ -294,6 +294,7 @@ module Groonga
             @context.dynamic_columns.apply_filtered(targets)
             yield(result_set)
             @context.shift
+            break
           end
         end
 
@@ -301,40 +302,29 @@ module Groonga
         def each_shard_executor(&block)
           enumerator = @context.enumerator
           target_range = enumerator.target_range
+          if @context.order == :descending
+            each_method = :reverse_each
+          else
+            each_method = :each
+          end
           if @context.need_look_ahead?
-            if @context.order == :descending
-              each_method = :reverse_each_with_index
-            else
-              each_method = :each_with_index
-            end
-            last_index = enumerator.size - 1
-            executors = []
             previous_executor = nil
-            # Keep the previous data for window function
-            is_first_executor = true
-            enumerator.send(each_method) do |shard, shard_range, i|
+            enumerator.send(each_method) do |shard, shard_range|
               @context.push
               current_executor = ShardExecutor.new(@context, shard, shard_range)
               if previous_executor
                 previous_executor.next_executor = current_executor
                 current_executor.previous_executor = previous_executor
                 yield(previous_executor)
-                @context.shift unless is_first_executor
-                is_first_executor &&= false
+                @context.shift unless previous_executor.shard.first?
+              end
+              if shard.last?
+                yield(current_executor)
+                @context.shift
               end
               previous_executor = current_executor
-              if i >= last_index
-                yield(previous_executor)
-                @context.shift
-                @context.shift unless is_first_executor
-              end
-            end            
-          else
-            if @context.order == :descending
-              each_method = :reverse_each
-            else
-              each_method = :each
             end
+          else
             enumerator.send(each_method) do |shard, shard_range|
               @context.push
               yield(ShardExecutor.new(@context, shard, shard_range))

kou · 2022-03-15T01:16:22Z

plugins/sharding/logical_enumerator.rb

      def each_shard_with_around(order)
        context = Context.instance
        prefix = "#{@logical_table}_"
+        unref_immediately = @options[:unref_immediately] || false


|| false is redundant.
If :unref_immediately isn't specified, @options[:unref_immediately] returns nil. nil is one of false values.

HashidaTKS · 2022-03-15T01:31:12Z

How about adding Shard#first? and Shard#last? instead of checking index?

Looks good!
I adopt this idea.

HashidaTKS · 2022-03-15T08:40:49Z

...logical_range_filter/columns/stage/filtered/window_function/month/time_classify_day.expected

@@ -70,9 +70,24 @@ logical_range_filter Logs   --shard_key timestamp   --columns[day].stage filtere
    ]
  ]
 ]
+#|-| [obj][open] <273>(<Logs_201703.timestamp>):<64>(<column:fix_size>)
+#|-| [obj][open] <272>(<Logs_201703>):<51>(<table:no_key>)


Seems that Logs_201703 is not closed (other tests seems to have the same issue), I am checking this.

HashidaTKS · 2022-03-15T08:52:31Z

Can we test this change by adding #@add-important-log-levels or something to existing tests?

I have added #$GRN_ENABLE_REFERENCE_COUNT=yes to all tests of logical_range_filter,
but not adding #@add-important-log-levels and log_level --level dump to the all tests, just changing log_level of tests that currently use it.
I will add them later ( in this PR ).

kou · 2022-03-15T08:54:19Z

We don't need to add #$GRN_ENABLE_REFERENCE_COUNT=yes to tests that don't verify open/close.

HashidaTKS · 2022-03-15T09:11:56Z

I intended to verify open/close at all tests under a plan to change current tests.
Okay, I will pick out tests that need to verify open/close.

HashidaTKS · 2022-03-16T02:48:05Z

...uite/sharding/logical_range_filter/columns/stage/filtered/window_function/month/min.expected

@@ -70,9 +70,22 @@ logical_range_filter Logs   --shard_key timestamp   --min '2017/03/15 01:00:00'
    ]
  ]
 ]
+#|-| [obj][open] <273>(<Logs_201703.timestamp>):<64>(<column:fix_size>)
+#|-| [obj][open] <272>(<Logs_201703>):<51>(<table:no_key>)


An opened table, Logs_201703 in this case, is not closed in cases below.

using time_classify_xxx with dynamic column

using window function with dynamic column

specifying a non existent column on output_column with specifying filter

select command also has these issues so I guess this is not the matter of logical_range_filter.
The commands to reproduce these are below.

common

plugin_register functions/time table_create Logs_20170315 TABLE_NO_KEY column_create Logs_20170315 timestamp COLUMN_SCALAR Time column_create Logs_20170315 price COLUMN_SCALAR UInt32 load --table Logs_20170315 [ {"timestamp": "2017/03/15 00:00:00", "price": 1000}, {"timestamp": "2017/03/15 11:00:00", "price": 900}, {"timestamp": "2017/03/15 12:00:00", "price": 300}, {"timestamp": "2017/03/15 13:00:00", "price": 200} ] log_level --level dump

Case 1: using time_classify_xxx with dynamic column

select Logs_20170315 --columns[day].stage filtered --columns[day].type Time --columns[day].flags COLUMN_SCALAR --columns[day].value 'time_classify_day(timestamp-36000000000)' --output_columns _id [[0,0.0,0.0],[[[4],[["_id","UInt32"]],[1],[2],[3],[4]]]] #|-| [obj][open] <272>(<Logs_20170315>):<51>(<table:no_key>) #|-| [obj][open] <273>(<Logs_20170315.timestamp>):<64>(<column:fix_size>) #|-| [obj][close] <273>(<Logs_20170315.timestamp>):<64>(<column:fix_size>)

Case 2: using window function with dynamic column

select Logs_20170315 --columns[price_per_day].stage filtered --columns[price_per_day].type UInt32 --columns[price_per_day].flags COLUMN_SCALAR --columns[price_per_day].value 'window_sum(price)' --columns[price_per_day].window.group_keys 'timestamp' --output_columns _id [[0,0.0,0.0],[[[4],[["_id","UInt32"]],[1],[2],[3],[4]]]] #|-| [obj][open] <272>(<Logs_20170315>):<51>(<table:no_key>) #|-| [obj][open] <274>(<Logs_20170315.price>):<64>(<column:fix_size>) #|-| [obj][open] <273>(<Logs_20170315.timestamp>):<64>(<column:fix_size>) #|-| [obj][close] <274>(<Logs_20170315.price>):<64>(<column:fix_size>) #|-| [obj][close] <273>(<Logs_20170315.timestamp>):<64>(<column:fix_size>)

Case 3: specifying a non existent column with output_column

select Logs_20170315 --filter 'price >= 300' --output_columns _id,non_existent [[0,0.0,0.0],[[[3],[["_id","UInt32"]],[1],[2],[3]]]] #|-| [obj][open] <272>(<Logs_20170315>):<51>(<table:no_key>) #|-| [obj][open] <274>(<Logs_20170315.price>):<64>(<column:fix_size>) #|-| [obj][close] <274>(<Logs_20170315.price>):<64>(<column:fix_size>)

so I guess this is not the matter of logical_range_filter.

Because of this, I will create a new PR to fix this.
I think this PR should focus on logical_range_filter.

It makes sense.

using time_classify_xxx with dynamic column

using window function with dynamic column

specifying a non existent column on output_column with specifying filter

These cases are also fixed by the change of db.c.

Could you split it to another pull request as you said?

However, Logs_201703 is still not be closed at this test case. I am investigating it.

Could you split it to another pull request as you said?

I see. I will create a new PR.

I have rebased onto master and updated tests and confirmed it is closed.

HashidaTKS · 2022-03-16T03:12:04Z

I have picked up tests for verifying open/close objects in the point of view below.

Targeting 3 or more shards
- using window function
- not using window function
Targeting 1 shard
- using window function
- not using window function
Having result_set
Not having result_set but not error (means reaching end)

shards are not closed in some cases, but it seems that it is not the matter of logical_range_filter, so I will fix it in another PR, I mentioned this at #1330 (comment) .

kou · 2022-03-24T00:42:47Z

plugins/sharding/logical_range_filter.rb

-          @enumerator = LogicalEnumerator.new("logical_range_filter", @input)
+          @enumerator = LogicalEnumerator.new("logical_range_filter",
+                                              @input,
+                                              { :unref_immediately => true })


Suggested change

{ :unref_immediately => true })

:unref_immediately => true)

I have fixed it.

kou · 2022-03-24T00:45:37Z

plugins/sharding/logical_range_filter.rb

+              if shard.last?
+                yield(current_executor)
+                @context.shift
+                break


Can we remove this break?

I have removed.

kou · 2022-03-24T00:56:33Z

plugins/sharding/logical_enumerator.rb

        end

        if shards.size == 2
          yield(shards[0], shards[1], nil)
        end
+        if unref_immediately
+          @shards.each(&:unref)
+          @shards.clear


How about using #unref?

diff --git a/plugins/sharding/logical_enumerator.rb b/plugins/sharding/logical_enumerator.rb index 0c2d334ee..86f87837e 100644 --- a/plugins/sharding/logical_enumerator.rb +++ b/plugins/sharding/logical_enumerator.rb @@ -24,6 +24,7 @@ module Groonga def unref @shards.each(&:unref) + @shards.clear end private @@ -104,10 +105,7 @@ module Groonga if shards.size == 2 yield(shards[0], shards[1], nil) end - if unref_immediately - @shards.each(&:unref) - @shards.clear - end + unref if unref_immediately end def initialize_parameters

I have changed to use #unref.
Additionaly, I have added @shard.clear to LogicalEnumerator.unref in order to ensure executing Shard.unref only once even if LogicalEnumerator.unref is called multiple times.

Also, I have changed to ensure executing this unref if unref_immediately because a caller of this function sometimes break a loop before reaching the end of this function.

kou · 2022-03-24T00:59:57Z

test/command/suite/sharding/logical_range_filter/columns/stage/filtered/filter.expected

@@ -88,8 +88,32 @@ logical_range_filter Logs   --shard_key timestamp   --columns[filtered_id].stage
    ]
  ]
 ]
+#|-| [obj][open] <263>(<Logs_20170315.timestamp>):<64>(<column:fix_size>)
+#|-| [obj][open] <262>(<Logs_20170315>):<51>(<table:no_key>)


This isn't closed.
Is this closed by #1333 and #1334, right?

Yes, once #1333 and #1334 are merged into master, I will rebase this branch on it.

And modify expected results.

I have rebased onto master and updated tests.

kou · 2022-03-24T01:00:05Z

test/command/suite/sharding/logical_range_filter/columns/stage/filtered/filter.expected

+#|-| [obj][close] <272>(<Times.logs_20170315>):<72>(<column:index>)
+#|-| [obj][close] <271>(<Times>):<49>(<table:pat_key>)
+#|-| [obj][open] <266>(<Logs_20170316.timestamp>):<64>(<column:fix_size>)
+#|-| [obj][open] <265>(<Logs_20170316>):<51>(<table:no_key>)


This isn't closed.
Is this closed by #1333 and #1334, right?

I have rebased onto master and updated tests.

kou · 2022-03-24T01:01:24Z

...d/suite/sharding/logical_range_filter/columns/stage/filtered/window_function/shards.expected

+#|-| [obj][open] <273>(<Logs_20170315.timestamp>):<64>(<column:fix_size>)
+#|-| [obj][open] <272>(<Logs_20170315>):<51>(<table:no_key>)
+#|-| [obj][open] <276>(<Logs_20170316.timestamp>):<64>(<column:fix_size>)
+#|-| [obj][open] <275>(<Logs_20170316>):<51>(<table:no_key>)


This isn't closed.
Is this closed by #1333 and #1334, right?

I have rebased onto master and updated tests and confirmed it is closed.

kou · 2022-03-24T01:01:59Z

...d/suite/sharding/logical_range_filter/columns/stage/filtered/window_function/shards.expected

+#|-| [obj][close] <277>(<Logs_20170316.price>):<64>(<column:fix_size>)
+#|-| [obj][close] <273>(<Logs_20170315.timestamp>):<64>(<column:fix_size>)
+#|-| [obj][open] <279>(<Logs_20170317.timestamp>):<64>(<column:fix_size>)
+#|-| [obj][open] <278>(<Logs_20170317>):<51>(<table:no_key>)


This isn't closed.
Is this closed by #1333 and #1334, right?

I have rebased onto master and updated tests and confirmed it is closed.

kou · 2022-03-24T01:02:38Z

...mmand/suite/sharding/logical_range_filter/columns/stage/filtered/window_function/shards.test

@@ -57,3 +61,5 @@ logical_range_filter Logs \
  --columns[price_per_day].window.group_keys 'day' \
  --output_columns _id,day,price_per_day
 #@collect-query-log false
+#@remove-ignore-log-pattern /\A\[io\]/
+#@remove-important-log-levels dump


Could you add a new line here?

I have fixed it.

kou · 2022-03-24T01:03:56Z

...and/suite/sharding/logical_range_filter/filter/match/nested_reference_vector/select.expected

+#|-| [obj][close] <262>(<Terms>):<49>(<table:pat_key>)
+#|-| [obj][open] <262>(<Terms>):<49>(<table:pat_key>)
+#|-| [obj][open] <272>(<Terms.users_name>):<72>(<column:index>)
+#|-| [obj][open] <263>(<Users>):<49>(<table:pat_key>)


This isn't closed.
Is this closed by #1333 and #1334, right?

I have rebased onto master and updated tests and confirmed it is closed.
However, the Users table repeat open and close.
I concern about it in term of performance...

kou · 2022-03-24T01:04:40Z

test/command/suite/sharding/logical_range_filter/limit/positive/no_offset.test

@@ -35,3 +39,6 @@ logical_range_filter Logs timestamp \
  --max_border "include" \
  --limit 4
 #@collect-query-log false
+log_level --level notice
+#@remove-ignore-log-pattern /\A\[io\]/
+#@remove-important-log-levels dump


Could you add a new line here?

I have fixed it.

- Abolish size and compute_size

Change to check not only debug log but also dump log

…tests" This reverts commit 8ec6682.

Revert unintended changes

Fit to ensure executing unref when unref_immediately is true Fix format

kou · 2022-03-24T07:09:39Z

Thanks.

HashidaTKS commented Mar 3, 2022

View reviewed changes

plugins/sharding/logical_range_filter.rb Outdated Show resolved Hide resolved

HashidaTKS force-pushed the unref_immediately branch from 0422e99 to a3bce9a Compare March 10, 2022 04:32

HashidaTKS changed the title ~~Add support for immediate un-reference of shards~~ logical_range_filter: Add support for immediate un-reference of shards Mar 10, 2022

HashidaTKS marked this pull request as ready for review March 10, 2022 08:23

HashidaTKS requested review from kou and komainu8 March 10, 2022 08:23

HashidaTKS force-pushed the unref_immediately branch from 09e9ca6 to c5b7540 Compare March 11, 2022 02:28

kou reviewed Mar 11, 2022

View reviewed changes

kou reviewed Mar 15, 2022

View reviewed changes

plugins/sharding/logical_enumerator.rb Outdated Show resolved Hide resolved

plugins/sharding/logical_enumerator.rb Show resolved Hide resolved

kou reviewed Mar 15, 2022

View reviewed changes

HashidaTKS commented Mar 15, 2022

View reviewed changes

HashidaTKS commented Mar 16, 2022

View reviewed changes

HashidaTKS force-pushed the unref_immediately branch from 8ae21bd to 07f3a44 Compare March 17, 2022 04:58

This was referenced Mar 17, 2022

Add necessary unref to grn_obj_get_accessor #1333

Merged

Add necessary unref to accessor.c and report.c #1334

Merged

kou reviewed Mar 24, 2022

View reviewed changes

HashidaTKS added 3 commits March 24, 2022 12:00

Add support for immediate un-reference in logical_range_filter

e1e7901

Rename *_stack to *_queue

335e220

Revert a comment

327d516

HashidaTKS added 9 commits March 24, 2022 12:00

Modify a method name

3203fc7

Modify details

4be6fed

Respond to the feedback

6f84fb3

- Abolish size and compute_size

Add GRN_ENABLE_REFERENCE_COUNT=yes to logical_range_filter tests

8c642b8

Change to check not only debug log but also dump log

Revert "Add GRN_ENABLE_REFERENCE_COUNT=yes to logical_range_filter …

445609d

…tests" This reverts commit 8ec6682.

Add Tests

13839f1

Revert unintended changes

Fix remove-important-log-levels of output_columns.test

2693928

Update expected test results

1ab1018

Respond to the feedback

09a05ea

Fit to ensure executing unref when unref_immediately is true Fix format

HashidaTKS force-pushed the unref_immediately branch from ba717ae to 09a05ea Compare March 24, 2022 03:21

HashidaTKS requested a review from kou March 24, 2022 05:00

kou merged commit 3c3f27f into groonga:master Mar 24, 2022

github-actions bot mentioned this pull request May 22, 2023

nginx: update bundles version 1.23.4 komainu8/groonga#1

Closed

@@ @@ -63,9 +72,35 @@ def each_internal(order) @@
                       end
                     end
+                    private

logical_range_filter: Add support for immediate un-reference of shards #1330

logical_range_filter: Add support for immediate un-reference of shards #1330

Conversation

HashidaTKS commented Mar 3, 2022 • edited Loading

Behavior before patched

Behavior after patched

HashidaTKS commented Mar 10, 2022

komainu8 commented Mar 11, 2022

HashidaTKS commented Mar 11, 2022

HashidaTKS commented Mar 11, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kou commented Mar 15, 2022

kou left a comment

Choose a reason for hiding this comment

kou Mar 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HashidaTKS commented Mar 15, 2022

HashidaTKS Mar 15, 2022 • edited Loading

Choose a reason for hiding this comment

HashidaTKS commented Mar 15, 2022 • edited Loading

kou commented Mar 15, 2022

HashidaTKS commented Mar 15, 2022 • edited Loading

HashidaTKS Mar 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HashidaTKS Mar 17, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HashidaTKS commented Mar 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HashidaTKS Mar 24, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HashidaTKS Mar 24, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HashidaTKS Mar 24, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kou commented Mar 24, 2022

HashidaTKS commented Mar 3, 2022 •

edited

Loading

kou Mar 15, 2022 •

edited

Loading

HashidaTKS Mar 15, 2022 •

edited

Loading

HashidaTKS commented Mar 15, 2022 •

edited

Loading

HashidaTKS commented Mar 15, 2022 •

edited

Loading

HashidaTKS Mar 16, 2022 •

edited

Loading

HashidaTKS Mar 17, 2022 •

edited

Loading

HashidaTKS commented Mar 16, 2022 •

edited

Loading

HashidaTKS Mar 24, 2022 •

edited

Loading

HashidaTKS Mar 24, 2022 •

edited

Loading

HashidaTKS Mar 24, 2022 •

edited

Loading