Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add necessary unref to report.c #1337

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Conversation

HashidaTKS
Copy link
Contributor

@HashidaTKS HashidaTKS commented Mar 24, 2022

Add necessary unref to report.c.

This patch fixes two cases.

Case 1: missing unref in grn_report_column

The test for checking the diff is below.

7d92e7e#diff-34e78064b3ddc8e91e84bb7301d928e19b908e8758e48b75eb0d8ce7257d5e2d

Case 2: missing unref in grn_report_accessor

The test for checking the diff is below.

7d92e7e#diff-6846c9fab6e8b8b2d9bb531e83a14cc1e834edc9551d1f87e003163ceb1e2e9b

Update expected test results
@HashidaTKS HashidaTKS requested a review from kou March 24, 2022 06:09
@kou kou merged commit 535800b into groonga:master Mar 24, 2022
@kou
Copy link
Member

kou commented Mar 24, 2022

I hope that you don't mix multiple cases to one pull request next time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants