logical_range_filter: separate window from logical_range_filter into an independent file #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Mar 25, 2022
plugins/sharding/window.rb
Outdated
| end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Sorry for forgetting it so many times...
I have fixed it.
|
Could you also update |
- Add a newline at the end of window.rb - Add window.rb into sources.am
|
Thank you for the review.
I have added |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate
windowfromlogical_range_filterinto an independent file.This is a preparation for modification of
logical_countto un-refer shards immediately likelogical_range_filter.