logical_range_filter: Separate a base of ExecuteContext into another class #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Mar 30, 2022
| @@ -0,0 +1,87 @@ | |||
| module Groonga | |||
| module Sharding | |||
| class ExecuteContextBase | |||
There was a problem hiding this comment.
How about StreamExecuteContext or something because this isn't suitable for non stream based execution such as logical_select?
There was a problem hiding this comment.
It makes sense.
I have renamed it.
HashidaTKS
force-pushed
the
separate_execute_context
branch
from
75efb4e
to
4510f63
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExecuteContextBase.ExecuteContextto inheriteExecuteContextBase.This is a preparation for #1341.