Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logical_range_filter: Move order to StreamExcuteContext #1347

Merged
merged 2 commits into from
Apr 1, 2022
Merged

logical_range_filter: Move order to StreamExcuteContext #1347

merged 2 commits into from
Apr 1, 2022

Conversation

HashidaTKS
Copy link
Contributor

Move the order attribute to StreamExcuteContext from ExecuteContext

@HashidaTKS HashidaTKS force-pushed the add_order_to_stream_execute_context branch from a79164f to db57eaf Compare March 31, 2022 06:36
kou
kou reviewed Mar 31, 2022
View reviewed changes
plugins/sharding/stream_execute_context.rb Outdated
:descending
else
message =
"[logical_range_filter] #{name} must be " +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use command_name here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I have overlooked.
I have fixed it.

@HashidaTKS HashidaTKS mentioned this pull request Mar 31, 2022
Merged
2 tasks
@kou kou merged commit b31dd34 into groonga:master Apr 1, 2022
@github-actions github-actions bot mentioned this pull request May 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HashidaTKS @kou