Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache-arrow: use 8.0.0 #1358

Merged
merged 4 commits into from
May 16, 2022
Merged

apache-arrow: use 8.0.0 #1358

merged 4 commits into from
May 16, 2022

Conversation

komainu8
Copy link
Member

No description provided.

@@ -47,7 +49,7 @@ on relational data model.
Summary: Runtime libraries for Groonga
Group: System Environment/Libraries
License: LGPLv2 and (MIT or GPLv2)
Requires: arrow-libs >= @APACHE_ARROW_VERSION@, arrow-libs < @APACHE_ARROW_NEXT_MAJOR_VERSION@.0.0
Requires: %{_arrow_libs} >= @APACHE_ARROW_VERSION@, %{_arrow_libs} < @APACHE_ARROW_NEXT_MAJOR_VERSION@.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just write like Requires: arrow@APACHE_ARROW_MAJOR_VERSION@-libs because package name includes major version information.

Because the package name included major version information.
@kou
Copy link
Member

kou commented May 16, 2022

Can we simplify BuildRequires: arrow-devel >= @APACHE_ARROW_VERSION@, arrow-devel < @APACHE_ARROW_NEXT_MAJOR_VERSION@.0.0 to BuildRequires: arrow-devel?

@komainu8
Copy link
Member Author

If we specify BuildRequires: arrow-devel, I think Apache Arrow does not update automatically.
Because we don't specify the version.

@kou
Copy link
Member

kou commented May 16, 2022

How about BuildRequires: arrow-devel >= @APACHE_ARROW_VERSION@?

@komainu8 komainu8 marked this pull request as ready for review May 16, 2022 23:55
@kou kou merged commit 56b23db into master May 16, 2022
@kou kou deleted the use-the-latest-apache-arrow branch May 16, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants